Skip to content

Conversation

@jojochuang
Copy link
Contributor

1. puts NVDIMM to the end of storage type enum to make sure compatibility.
2. adds check to make sure the software layout version is satisfied

Co-authored-by: su xu <[email protected]>
Co-authored-by: huangtianhua <[email protected]>
Co-authored-by: YaYun-Wang <[email protected]>

Signed-off-by: Mingliang Liu <[email protected]>
Signed-off-by: Ayush Saxena <[email protected]>
Signed-off-by: Vinayakumar B <[email protected]>

This is the same PR as (#2377) except the layout version was updated to avoid conflict with HDFS-15666.

…#2377)

    1. puts NVDIMM to the end of storage type enum to make sure compatibility.
    2. adds check to make sure the software layout version is satisfied

    Co-authored-by: su xu <[email protected]>
    Co-authored-by: huangtianhua <[email protected]>
    Co-authored-by: YaYun-Wang <[email protected]>

    Signed-off-by: Mingliang Liu <[email protected]>
    Signed-off-by: Ayush Saxena <[email protected]>
    Signed-off-by: Vinayakumar B <[email protected]>

Change-Id: I3c58beef50730827a09b3c968e9ad637baa57d44
@jojochuang jojochuang requested a review from ayushtkn April 26, 2021 04:00
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, if the jenkins don't complain.
Thanx for taking care

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 15m 29s Maven dependency ordering for branch
+1 💚 mvninstall 20m 25s trunk passed
+1 💚 compile 20m 46s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 compile 18m 3s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 checkstyle 3m 51s trunk passed
+1 💚 mvnsite 3m 56s trunk passed
+1 💚 javadoc 2m 59s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 4m 27s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 spotbugs 7m 2s trunk passed
+1 💚 shadedclient 14m 39s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for patch
+1 💚 mvninstall 2m 37s the patch passed
+1 💚 compile 20m 2s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javac 20m 2s the patch passed
+1 💚 compile 17m 59s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 javac 17m 59s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 3m 51s /results-checkstyle-root.txt root: The patch generated 1 new + 407 unchanged - 2 fixed = 408 total (was 409)
+1 💚 mvnsite 3m 56s the patch passed
+1 💚 javadoc 2m 59s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 4m 20s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 spotbugs 7m 39s the patch passed
+1 💚 shadedclient 14m 59s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 17m 44s hadoop-common in the patch passed.
-1 ❌ unit 225m 17s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
-1 ❌ unit 18m 19s /patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt hadoop-hdfs-rbf in the patch passed.
+1 💚 asflicense 1m 8s The patch does not generate ASF License warnings.
456m 54s
Reason Tests
Failed junit tests hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys
hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2955/1/artifact/out/Dockerfile
GITHUB PR #2955
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux b2d1212677cb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 5971f1b
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2955/1/testReport/
Max. process+thread count 3022 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2955/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@jojochuang
Copy link
Contributor Author

Failed tests do not reproduce locally. Merging the PR.

@jojochuang jojochuang merged commit b2e5476 into apache:trunk Apr 29, 2021
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
…#2377) (apache#2955)

1. puts NVDIMM to the end of storage type enum to make sure compatibility.
2. adds check to make sure the software layout version is satisfied

Co-authored-by: su xu <[email protected]>
Co-authored-by: huangtianhua <[email protected]>
Co-authored-by: YaYun-Wang <[email protected]>

Signed-off-by: Mingliang Liu <[email protected]>
Signed-off-by: Ayush Saxena <[email protected]>
Signed-off-by: Vinayakumar B <[email protected]>

Change-Id: I3c58beef50730827a09b3c968e9ad637baa57d44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants