Skip to content

Conversation

@zhangshuyan0
Copy link
Contributor

HDFS-15963. Unreleased volume references cause an infinite loop. (#2889) Contributed by Shuyan Zhang.

Reviewed-by: Wei-Chiu Chuang [email protected]
Reviewed-by: He Xiaoqiao [email protected]

…che#2889) Contributed by Shuyan Zhang.

Reviewed-by: Wei-Chiu Chuang <[email protected]>
Reviewed-by: He Xiaoqiao <[email protected]>
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 9s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 34m 12s branch-3.3 passed
+1 💚 compile 1m 18s branch-3.3 passed
+1 💚 checkstyle 0m 51s branch-3.3 passed
+1 💚 mvnsite 1m 28s branch-3.3 passed
+1 💚 javadoc 1m 33s branch-3.3 passed
+1 💚 spotbugs 3m 23s branch-3.3 passed
+1 💚 shadedclient 19m 0s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 18s the patch passed
+1 💚 compile 1m 10s the patch passed
+1 💚 javac 1m 10s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 44s the patch passed
+1 💚 mvnsite 1m 18s the patch passed
+1 💚 javadoc 1m 25s the patch passed
+1 💚 spotbugs 3m 19s the patch passed
+1 💚 shadedclient 18m 44s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 240m 21s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 48s The patch does not generate ASF License warnings.
329m 26s
Reason Tests
Failed junit tests hadoop.hdfs.TestGetFileChecksum
hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys
hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks
hadoop.hdfs.TestReconstructStripedFile
hadoop.hdfs.TestReconstructStripedFileWithValidator
hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2941/1/artifact/out/Dockerfile
GITHUB PR #2941
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 950af898b8fb 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / b2cd7e4
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~18.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2941/1/testReport/
Max. process+thread count 3191 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2941/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@jojochuang jojochuang requested a review from Hexiaoqiao April 21, 2021 10:10
Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Hexiaoqiao Hexiaoqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhangshuyan0 for your works. +1 from my side. Will commit shortly if no other comments.
Check failed unit tests and seems no related to this PR.

@Hexiaoqiao Hexiaoqiao merged commit 9f2db2c into apache:branch-3.3 Apr 21, 2021
asfgit pushed a commit that referenced this pull request Jun 16, 2021
…) Contributed by Shuyan Zhang.

Reviewed-by: Wei-Chiu Chuang <[email protected]>
Reviewed-by: He Xiaoqiao <[email protected]>
(cherry picked from commit 9f2db2c)
tasanuma pushed a commit to tasanuma/hadoop that referenced this pull request Nov 17, 2021
…che#2941) Contributed by Shuyan Zhang.

Reviewed-by: Wei-Chiu Chuang <[email protected]>
Reviewed-by: He Xiaoqiao <[email protected]>
(cherry picked from commit 9f2db2c)
tasanuma added a commit that referenced this pull request Nov 18, 2021
…ributed by Shuyan Zhang. (#2941, #3668)

Reviewed-by: Wei-Chiu Chuang <[email protected]>
Reviewed-by: He Xiaoqiao <[email protected]>
(cherry picked from commit 9f2db2c)

Co-authored-by: zhangshuyan0 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants