Skip to content

HADOOP-17650. Bump solr to unblock build failure with Maven 3.8.1 #2939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jojochuang merged 1 commit into from
Apr 26, 2021
Merged

HADOOP-17650. Bump solr to unblock build failure with Maven 3.8.1 #2939

jojochuang merged 1 commit into from
Apr 26, 2021

Conversation

@virajjasani
Copy link
Contributor

@virajjasani virajjasani commented Apr 20, 2021 •
edited by smengcl
Loading

@hadoop-yetus

This comment has been minimized.

Sign in to view
@hadoop-yetus

This comment has been minimized.

Sign in to view
@hadoop-yetus

This comment has been minimized.

Sign in to view
@virajjasani
Copy link
Contributor Author

virajjasani commented Apr 22, 2021

@smengcl could you please review the PR?
Thanks

smengcl
smengcl approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @virajjasani for the patch. lgtm.

btw would you think there could be a compatibility issue in hadoop-yarn-applications-catalog-webapp since it's used there? I think not as new solr client should just be compatible with older solr server, right?

@virajjasani
Copy link
Contributor Author

virajjasani commented Apr 22, 2021

Nice question @smengcl. I think we should update compatibility guidelines (release notes in Jira) stating that since we are upgrading SolrJ to 8.8.2, it's good to upgrade Solr server accordingly before upgrading entire Hadoop cluster to 3.4.0 (assuming we want to keep this in trunk only for now).

@virajjasani
Copy link
Contributor Author

virajjasani commented Apr 23, 2021 •
edited
Loading

@smengcl I have updated release notes on Jira HADOOP-17650
Does it sound good to you?
Thanks

@hadoop-yetus
Copy link

hadoop-yetus commented Apr 24, 2021

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 15m 27s Maven dependency ordering for branch
+1 💚 mvninstall 22m 52s trunk passed
+1 💚 compile 22m 19s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 compile 18m 59s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 checkstyle 4m 4s trunk passed
+1 💚 mvnsite 1m 16s trunk passed
+1 💚 javadoc 0m 54s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 52s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗 spotbugs 0m 29s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+1 💚 shadedclient 16m 30s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 2m 31s Maven dependency ordering for patch
+1 💚 mvninstall 0m 51s the patch passed
+1 💚 compile 21m 44s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javac 21m 44s the patch passed
+1 💚 compile 18m 54s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 javac 18m 54s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 3m 57s /results-checkstyle-root.txt root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 mvnsite 1m 15s the patch passed
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 54s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 53s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗 spotbugs 0m 26s hadoop-project has no data from spotbugs
+1 💚 shadedclient 16m 50s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 24s hadoop-project in the patch passed.
+1 💚 unit 1m 0s hadoop-yarn-applications-catalog-webapp in the patch passed.
+1 💚 asflicense 0m 46s The patch does not generate ASF License warnings.
179m 55s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2939/4/artifact/out/Dockerfile
GITHUB PR #2939
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle
uname Linux 5e8180284a07 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c6ae2b6
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2939/4/testReport/
Max. process+thread count 599 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2939/4/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@virajjasani
Copy link
Contributor Author

virajjasani commented Apr 26, 2021

FYI @aajisaka if you would like to take a look

@jojochuang jojochuang merged commit 538ce9c into apache:trunk Apr 26, 2021
aajisaka
aajisaka reviewed Apr 26, 2021
View reviewed changes
Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for being late.

@smengcl
Copy link
Contributor

smengcl commented Apr 26, 2021

@smengcl I have updated release notes on Jira HADOOP-17650
Does it sound good to you?
Thanks

Release notes looks good. Thanks!

@virajjasani virajjasani deleted the HADOOP-17650-trunk branch September 24, 2021 12:58
charles1614 pushed a commit to charles1614/hadoop that referenced this pull request Nov 5, 2021
@virajjasani @charles1614
HADOOP-17650. Bump solr to unblock build failure with Maven 3.8.1 (ap…
a2b0871 
…ache#2939)

Reviewed-by: Siyao Meng <[email protected]>
charles1614 pushed a commit to charles1614/hadoop that referenced this pull request Nov 8, 2021
@virajjasani @charles1614
HADOOP-17650. Bump solr to unblock build failure with Maven 3.8.1 (ap…
012a936 
…ache#2939)

Reviewed-by: Siyao Meng <[email protected]>
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
@virajjasani
HADOOP-17650. Bump solr to unblock build failure with Maven 3.8.1 (ap…
6a7a79d 
…ache#2939)

Reviewed-by: Siyao Meng <[email protected]>
steveloughran pushed a commit to steveloughran/hadoop that referenced this pull request Apr 20, 2022
@virajjasani @steveloughran
HADOOP-17650. Bump solr to unblock build failure with Maven 3.8.1 (ap…
3328926 
…ache#2939)

Reviewed-by: Siyao Meng <[email protected]>
@steveloughran steveloughran mentioned this pull request Apr 20, 2022
Merged
4 tasks
steveloughran added a commit that referenced this pull request Apr 20, 2022
@steveloughran
HADOOP-17650. Bump solr to unblock build failure with Maven 3.8.1 (#2939
caecec4 
)


Reviewed-by: Siyao Meng <[email protected]>

Contributed by Viraj Jasani
asfgit pushed a commit that referenced this pull request Apr 20, 2022
@steveloughran
HADOOP-17650. Bump solr to unblock build failure with Maven 3.8.1 (#2939
09badd7 
)

Reviewed-by: Siyao Meng <[email protected]>

Contributed by Viraj Jasani

Change-Id: I67a6a1b7464044318a089bd82ffa51d9d37aea7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aajisaka aajisaka aajisaka left review comments

@jojochuang jojochuang jojochuang approved these changes

@smengcl smengcl smengcl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@virajjasani @hadoop-yetus @smengcl @jojochuang @aajisaka