HDFS-15991. Add location into datanode info for NameNodeMXBean #2933

tomscut · 2021-04-19T15:04:04Z

hadoop-yetus · 2021-04-19T20:22:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 38s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 23s		trunk passed
+1 💚	compile	1m 22s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 17s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 3s		trunk passed
+1 💚	mvnsite	1m 23s		trunk passed
+1 💚	javadoc	0m 53s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 27s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	3m 9s		trunk passed
+1 💚	shadedclient	16m 16s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 12s		the patch passed
+1 💚	compile	1m 12s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	1m 12s		the patch passed
+1 💚	compile	1m 6s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	1m 6s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 53s		the patch passed
+1 💚	mvnsite	1m 11s		the patch passed
+1 💚	javadoc	0m 44s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 20s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	3m 7s		the patch passed
+1 💚	shadedclient	15m 59s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	230m 18s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 43s		The patch does not generate ASF License warnings.
		317m 36s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2933/1/artifact/out/Dockerfile
GITHUB PR	#2933
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 90e25c73c94f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `31726f4`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2933/1/testReport/
Max. process+thread count	3680 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2933/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

tomscut · 2021-04-21T03:10:26Z

Hi @tasanuma , could you please review the code. Thanks a lot.

tasanuma · 2021-04-21T10:43:10Z

@tomscut Thanks for working on this. It makes sense to me. Some comments,

Could you add unit tests? We may want to edit TestNameNodeMXBean.
Router WebUI uses the location information. Could you do the same for NameNode WebUI?

Router WebUI (federationhealth.html)

NameNode WebUI (dfshealth.html)

tomscut · 2021-04-21T13:14:05Z

@tomscut Thanks for working on this. It makes sense to me. Some comments,

Could you add unit tests? We may want to edit TestNameNodeMXBean.

Router WebUI uses the location information. Could you do the same for NameNode WebUI?

Router WebUI (federationhealth.html)

NameNode WebUI (dfshealth.html)

Thanks @tasanuma for your review and comment. I'll refine that ASAP.

tomscut · 2021-04-23T12:59:46Z

@tomscut Thanks for working on this. It makes sense to me. Some comments,

Could you add unit tests? We may want to edit TestNameNodeMXBean.

Router WebUI uses the location information. Could you do the same for NameNode WebUI?

Router WebUI (federationhealth.html)

NameNode WebUI (dfshealth.html)

Thanks @tasanuma for your review and comment. I'll refine that ASAP.

Hi @tasanuma , I fix this problem. IMO, the NameNode UI does not need to show NS. What do you think?

hadoop-yetus · 2021-04-23T19:05:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 46s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 28s		Maven dependency ordering for branch
+1 💚	mvninstall	21m 21s		trunk passed
+1 💚	compile	4m 55s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	4m 50s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 14s		trunk passed
+1 💚	mvnsite	2m 6s		trunk passed
+1 💚	javadoc	1m 35s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 19s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	4m 23s		trunk passed
+1 💚	shadedclient	14m 16s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 27s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 50s		the patch passed
+1 💚	compile	5m 21s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	5m 21s		the patch passed
+1 💚	compile	4m 47s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	4m 47s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 21s	/results-checkstyle-hadoop-hdfs-project.txt	hadoop-hdfs-project: The patch generated 1 new + 177 unchanged - 0 fixed = 178 total (was 177)
+1 💚	mvnsite	2m 0s		the patch passed
+1 💚	javadoc	1m 22s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 16s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	5m 10s		the patch passed
+1 💚	shadedclient	16m 14s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	243m 41s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
-1 ❌	unit	17m 59s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 47s		The patch does not generate ASF License warnings.
		378m 23s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
	hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
	hadoop.hdfs.TestRollingUpgrade
	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys
	hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2933/2/artifact/out/Dockerfile
GITHUB PR	#2933
Optional Tests	dupname asflicense shadedclient codespell compile javac javadoc mvninstall mvnsite unit spotbugs checkstyle
uname	Linux 2df686516e8b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `4dd9c56`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2933/2/testReport/
Max. process+thread count	3335 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2933/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-04-25T10:17:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 42s		Maven dependency ordering for branch
+1 💚	mvninstall	20m 21s		trunk passed
+1 💚	compile	4m 47s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	4m 27s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 15s		trunk passed
+1 💚	mvnsite	2m 6s		trunk passed
+1 💚	javadoc	1m 32s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 23s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	4m 19s		trunk passed
+1 💚	shadedclient	16m 32s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 58s		the patch passed
+1 💚	compile	5m 12s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	5m 12s		the patch passed
+1 💚	compile	4m 38s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	4m 38s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 6s		the patch passed
+1 💚	mvnsite	1m 49s		the patch passed
+1 💚	javadoc	1m 20s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 6s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	4m 24s		the patch passed
+1 💚	shadedclient	14m 19s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	231m 11s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
-1 ❌	unit	18m 0s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 46s		The patch does not generate ASF License warnings.
		363m 25s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys
	hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2933/3/artifact/out/Dockerfile
GITHUB PR	#2933
Optional Tests	dupname asflicense shadedclient codespell compile javac javadoc mvninstall mvnsite unit spotbugs checkstyle
uname	Linux a4e3f5406bb7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `990157b`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2933/3/testReport/
Max. process+thread count	3722 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2933/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

tasanuma · 2021-04-26T09:37:34Z

Thanks for updating the PR, @tomscut.

IMO, the NameNode UI does not need to show NS. What do you think?

I agree with you.
The latest commit looks pretty good to me. And the failed tests aren't related.

tasanuma · 2021-04-26T09:39:01Z

Merged to trunk. Thanks for your contribution, @tomscut!

tasanuma · 2021-04-26T09:51:10Z

I'm planning to backport HDFS-15358 to branch-3.3. After that, I will cherry-pick this PR to branch-3.3.

tomscut · 2021-04-26T11:09:48Z

Merged to trunk. Thanks for your contribution, @tomscut!

Thanks @tasanuma for your review and merge.

Signed-off-by: Takanobu Asanuma <[email protected]> (cherry picked from commit b968fa0)

…e#2933) Signed-off-by: Takanobu Asanuma <[email protected]>

HDFS-15991. Add location into datanode info for NameNodeMXBean

31726f4

improve the Web UI, improve the unit test

4dd9c56

fix checkstyle

990157b

tasanuma approved these changes Apr 26, 2021

View reviewed changes

tasanuma merged commit b968fa0 into apache:trunk Apr 26, 2021

tasanuma pushed a commit that referenced this pull request Apr 28, 2021

HDFS-15991. Add location into datanode info for NameNodeMXBean (#2933)

0e9042f

Signed-off-by: Takanobu Asanuma <[email protected]> (cherry picked from commit b968fa0)

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021

HDFS-15991. Add location into datanode info for NameNodeMXBean (apach…

ddaffdc

…e#2933) Signed-off-by: Takanobu Asanuma <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-15991. Add location into datanode info for NameNodeMXBean #2933

HDFS-15991. Add location into datanode info for NameNodeMXBean #2933

Uh oh!

tomscut commented Apr 19, 2021

Uh oh!

hadoop-yetus commented Apr 19, 2021

Uh oh!

tomscut commented Apr 21, 2021

Uh oh!

tasanuma commented Apr 21, 2021

Uh oh!

tomscut commented Apr 21, 2021

Uh oh!

tomscut commented Apr 23, 2021

Uh oh!

hadoop-yetus commented Apr 23, 2021

Uh oh!

hadoop-yetus commented Apr 25, 2021

Uh oh!

tasanuma commented Apr 26, 2021

Uh oh!

tasanuma commented Apr 26, 2021

Uh oh!

tasanuma commented Apr 26, 2021

Uh oh!

tomscut commented Apr 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HDFS-15991. Add location into datanode info for NameNodeMXBean #2933

HDFS-15991. Add location into datanode info for NameNodeMXBean #2933

Uh oh!

Conversation

tomscut commented Apr 19, 2021

Uh oh!

hadoop-yetus commented Apr 19, 2021

Uh oh!

tomscut commented Apr 21, 2021

Uh oh!

tasanuma commented Apr 21, 2021

Uh oh!

tomscut commented Apr 21, 2021

Uh oh!

tomscut commented Apr 23, 2021

Uh oh!

hadoop-yetus commented Apr 23, 2021

Uh oh!

hadoop-yetus commented Apr 25, 2021

Uh oh!

tasanuma commented Apr 26, 2021

Uh oh!

tasanuma commented Apr 26, 2021

Uh oh!

tasanuma commented Apr 26, 2021

Uh oh!

tomscut commented Apr 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants