Skip to content

HDFS-15974. RBF: Unable to display the datanode UI of the router #2915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tasanuma merged 2 commits into from
Apr 23, 2021
Merged

HDFS-15974. RBF: Unable to display the datanode UI of the router #2915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51b6759
Fix RBF does not display datanode UI
Apr 16, 2021
1ac78a8
return to empty set and add test
Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...f/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/NamenodeBeanMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,7 +855,7 @@ public long getNumberOfSnapshottableDirs() {

@Override
public String getEnteringMaintenanceNodes() {
return "N/A";
return "{}";
}

@Override
Expand Down
8 changes: 8 additions & 0 deletions ...hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1748,6 +1748,14 @@ public void testRBFMetricsMethodsRelayOnStateStore() {
assertEquals(0, metrics.getNumLiveNodes());
}

@Test
public void testNamenodeMetricsEnteringMaintenanceNodes() throws IOException {
final NamenodeBeanMetrics metrics =
router.getRouter().getNamenodeMetrics();

assertEquals("{}", metrics.getEnteringMaintenanceNodes());
}

@Test
public void testCacheAdmin() throws Exception {
DistributedFileSystem routerDFS = (DistributedFileSystem) routerFS;
Expand Down