HADOOP-17608. Fix TestKMS failure #2880

aajisaka · 2021-04-09T05:59:28Z

HADOOP-16524 removed the reloader thread, so the related tests in TestKMS fail. Remove these.

hadoop-yetus · 2021-04-09T08:34:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 34s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 16s		trunk passed
+1 💚	compile	20m 45s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	17m 57s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	0m 38s		trunk passed
+1 💚	mvnsite	0m 46s		trunk passed
+1 💚	javadoc	0m 35s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 36s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	0m 58s		trunk passed
+1 💚	shadedclient	14m 30s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s		the patch passed
+1 💚	compile	20m 11s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	20m 11s		the patch passed
+1 💚	compile	18m 0s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	18m 0s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 36s	/results-checkstyle-hadoop-common-project_hadoop-kms.txt	hadoop-common-project/hadoop-kms: The patch generated 2 new + 92 unchanged - 2 fixed = 94 total (was 94)
+1 💚	mvnsite	0m 42s		the patch passed
+1 💚	javadoc	0m 39s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 37s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	1m 5s		the patch passed
+1 💚	shadedclient	14m 28s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	3m 38s		hadoop-kms in the patch passed.
+1 💚	asflicense	0m 56s		The patch does not generate ASF License warnings.
		154m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2880/1/artifact/out/Dockerfile
GITHUB PR	#2880
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 15b1100655be 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `b2359e8`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2880/1/testReport/
Max. process+thread count	690 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2880/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-04-10T18:41:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 35s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 0s		trunk passed
+1 💚	compile	20m 31s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	18m 1s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	0m 37s		trunk passed
+1 💚	mvnsite	0m 45s		trunk passed
+1 💚	javadoc	0m 40s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 38s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	0m 56s		trunk passed
+1 💚	shadedclient	14m 20s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 21s		the patch passed
+1 💚	compile	19m 55s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	19m 55s		the patch passed
+1 💚	compile	18m 6s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	18m 6s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 36s		hadoop-common-project/hadoop-kms: The patch generated 0 new + 92 unchanged - 2 fixed = 92 total (was 94)
+1 💚	mvnsite	0m 43s		the patch passed
+1 💚	javadoc	0m 40s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 37s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	1m 4s		the patch passed
+1 💚	shadedclient	14m 21s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	3m 39s		hadoop-kms in the patch passed.
+1 💚	asflicense	0m 55s		The patch does not generate ASF License warnings.
		155m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2880/2/artifact/out/Dockerfile
GITHUB PR	#2880
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux ae25abb66d5a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `62ceeaa`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2880/2/testReport/
Max. process+thread count	718 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2880/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

iwasakims

+1.

Do you think other tests refering SSL_MONITORING_THREAD_NAME (such as TestURLConnectionFactory and TestTimelineClient) should be fixed too?

aajisaka · 2021-04-12T02:44:06Z

Thank you @iwasakims!

SSL_MONITORING_THREAD_NAME is different from the truststore reloader thread, so those tests pass. However, I think the tests are flaky due to the same reason as #2828, and we should fix them.

aajisaka · 2021-04-12T02:50:25Z

TestTimelineClient -> YARN-10568

Reviewed-by: Masatake Iwasaki <[email protected]> (cherry picked from commit 2bd810a)

Reviewed-by: Masatake Iwasaki <[email protected]> (cherry picked from commit 2bd810a) (cherry picked from commit 77315ab) Conflicts: hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java

Reviewed-by: Masatake Iwasaki <[email protected]> (cherry picked from commit 2bd810a) (cherry picked from commit 77315ab) Conflicts: hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java Co-authored-by: Akira Ajisaka <[email protected]>

Reviewed-by: Masatake Iwasaki <[email protected]> (cherry picked from commit 2bd810a) (cherry picked from commit 77315ab) Conflicts: hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java Co-authored-by: Akira Ajisaka <[email protected]> (cherry picked from commit 289c7d9)

Reviewed-by: Masatake Iwasaki <[email protected]>

HADOOP-17608. TestKMS fails

b2359e8

[checkstyle] Removed unused imports.

62ceeaa

iwasakims approved these changes Apr 12, 2021

View reviewed changes

aajisaka merged commit 2bd810a into apache:trunk Apr 12, 2021

aajisaka deleted the HADOOP-17608-2 branch April 12, 2021 03:54

aajisaka added a commit that referenced this pull request Apr 12, 2021

HADOOP-17608. Fix TestKMS failure (#2880)

77315ab

Reviewed-by: Masatake Iwasaki <[email protected]> (cherry picked from commit 2bd810a)

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021

HADOOP-17608. Fix TestKMS failure (apache#2880)

45bba39

Reviewed-by: Masatake Iwasaki <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-17608. Fix TestKMS failure #2880

HADOOP-17608. Fix TestKMS failure #2880

Uh oh!

aajisaka commented Apr 9, 2021

Uh oh!

hadoop-yetus commented Apr 9, 2021

Uh oh!

hadoop-yetus commented Apr 10, 2021

Uh oh!

iwasakims left a comment

Uh oh!

aajisaka commented Apr 12, 2021

Uh oh!

aajisaka commented Apr 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HADOOP-17608. Fix TestKMS failure #2880

HADOOP-17608. Fix TestKMS failure #2880

Uh oh!

Conversation

aajisaka commented Apr 9, 2021

Uh oh!

hadoop-yetus commented Apr 9, 2021

Uh oh!

hadoop-yetus commented Apr 10, 2021

Uh oh!

iwasakims left a comment

Choose a reason for hiding this comment

Uh oh!

aajisaka commented Apr 12, 2021

Uh oh!

aajisaka commented Apr 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants