-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-15955. Make explicit_bzero cross platform #2875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
goiri
merged 2 commits into
apache:trunk
from
GauthamBanasandra:explicit-bzero-x-platform
Apr 8, 2021
Merged
HDFS-15955. Make explicit_bzero cross platform #2875
goiri
merged 2 commits into
apache:trunk
from
GauthamBanasandra:explicit-bzero-x-platform
Apr 8, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The function explicit_bzero isn't available in Visual C++. Need to make this cross platform.
Member
Author
|
Here's a blog explaining why we need to use SecureZeroMemory and its equivalent on other platforms - https://devblogs.microsoft.com/oldnewthing/20130529-00/?p=4223. |
* Added unit test for ClearBufferSafely.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Apr 8, 2021
kiran-maturi
pushed a commit
to kiran-maturi/hadoop
that referenced
this pull request
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in Visual C++. Need to make this cross platform.