HADOOP-17624. Remove any rocksdb exclusion code. by jojochuang · Pull Request #2867 · apache/hadoop

jojochuang · 2021-04-06T03:17:43Z

The code compiles locally. No additional tests added.

Change-Id: I1d0e6dbe632cb8dafd2abb5c4a9e16fa8b487b72 (cherry picked from commit 7234b1d32fdcd093c77b8c8e0c99041b3d8d891a)

Change-Id: Ia92a71c3276b8bf3e88f09b042836d7ae1c95f37

This reverts commit 291b724.

virajjasani

+1 (non-binding) now that Ozone is separate project

hadoop-yetus · 2021-04-06T06:36:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 35s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 29s		Maven dependency ordering for branch
+1 💚	mvninstall	21m 48s		trunk passed
+1 💚	compile	23m 26s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	20m 32s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	3m 56s		trunk passed
+1 💚	mvnsite	2m 29s		trunk passed
+1 💚	javadoc	2m 23s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 23s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗	spotbugs	0m 48s		branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file (spotbugsXml.xml)
+0 🆗	spotbugs	0m 47s		branch/hadoop-client-modules/hadoop-client-check-test-invariants no spotbugs output file (spotbugsXml.xml)
+1 💚	shadedclient	14m 18s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 30s		Maven dependency ordering for patch
+1 💚	mvninstall	5m 6s		the patch passed
+1 💚	compile	22m 38s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	22m 38s		the patch passed
+1 💚	compile	20m 32s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	20m 32s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	3m 54s		the patch passed
+1 💚	mvnsite	2m 28s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	xml	0m 2s		The patch has no ill-formed XML file.
+1 💚	javadoc	2m 19s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 18s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗	spotbugs	0m 47s		hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs
+0 🆗	spotbugs	0m 47s		hadoop-client-modules/hadoop-client-check-test-invariants has no data from spotbugs
+1 💚	shadedclient	14m 8s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	3m 30s		hadoop-auth in the patch passed.
+1 💚	unit	0m 47s		hadoop-client-minicluster in the patch passed.
+1 💚	unit	0m 43s		hadoop-client-check-test-invariants in the patch passed.
+1 💚	asflicense	1m 5s		The patch does not generate ASF License warnings.
		197m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2867/1/artifact/out/Dockerfile
GITHUB PR	#2867
Optional Tests	dupname asflicense mvnsite unit shadedclient codespell shellcheck shelldocs compile javac javadoc mvninstall xml spotbugs checkstyle
uname	Linux d96516ed159f 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `226c289`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2867/1/testReport/
Max. process+thread count	685 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-auth hadoop-client-modules/hadoop-client-minicluster hadoop-client-modules/hadoop-client-check-test-invariants U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2867/1/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-04-06T06:36:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 25s		Maven dependency ordering for branch
+1 💚	mvninstall	21m 33s		trunk passed
+1 💚	compile	23m 21s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	20m 24s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	3m 55s		trunk passed
+1 💚	mvnsite	2m 27s		trunk passed
+1 💚	javadoc	2m 21s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 22s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗	spotbugs	0m 47s		branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file (spotbugsXml.xml)
+0 🆗	spotbugs	0m 48s		branch/hadoop-client-modules/hadoop-client-check-test-invariants no spotbugs output file (spotbugsXml.xml)
+1 💚	shadedclient	14m 27s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 28s		Maven dependency ordering for patch
+1 💚	mvninstall	5m 4s		the patch passed
+1 💚	compile	22m 42s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	22m 42s		the patch passed
+1 💚	compile	20m 28s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	20m 28s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	3m 55s		the patch passed
+1 💚	mvnsite	2m 24s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	xml	0m 2s		The patch has no ill-formed XML file.
+1 💚	javadoc	2m 18s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	2m 18s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗	spotbugs	0m 48s		hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs
+0 🆗	spotbugs	0m 46s		hadoop-client-modules/hadoop-client-check-test-invariants has no data from spotbugs
+1 💚	shadedclient	14m 22s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	3m 28s		hadoop-auth in the patch passed.
+1 💚	unit	0m 46s		hadoop-client-minicluster in the patch passed.
+1 💚	unit	0m 44s		hadoop-client-check-test-invariants in the patch passed.
+1 💚	asflicense	1m 3s		The patch does not generate ASF License warnings.
		196m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2867/2/artifact/out/Dockerfile
GITHUB PR	#2867
Optional Tests	dupname asflicense mvnsite unit shadedclient codespell shellcheck shelldocs compile javac javadoc mvninstall xml spotbugs checkstyle
uname	Linux ef469021ab89 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `226c289`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2867/2/testReport/
Max. process+thread count	630 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-auth hadoop-client-modules/hadoop-client-minicluster hadoop-client-modules/hadoop-client-check-test-invariants U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2867/2/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

elek

+1

It's added by the Ozone development (which is already moved out) and couldn't see any other usage of rocksdb in the code.

Thanks the patch @jojochuang

jojochuang · 2021-04-07T04:52:33Z

Merged. Thanks both for the review!

Reviewed-by: Márton Elek <elek@apache.org> Reviewed-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit f608cda)

Reviewed-by: Márton Elek <elek@apache.org> Reviewed-by: Viraj Jasani <vjasani@apache.org>

jojochuang added 3 commits April 6, 2021 10:23

patch to remove Jetty-server inclusion in hadoop-auth.

291b724

Change-Id: I1d0e6dbe632cb8dafd2abb5c4a9e16fa8b487b72 (cherry picked from commit 7234b1d32fdcd093c77b8c8e0c99041b3d8d891a)

HADOOP-17624. Remove any rocksdb exclusion code.

2cda29f

Change-Id: Ia92a71c3276b8bf3e88f09b042836d7ae1c95f37

Revert "patch to remove Jetty-server inclusion in hadoop-auth."

226c289

This reverts commit 291b724.

virajjasani approved these changes Apr 6, 2021

View reviewed changes

jojochuang requested a review from elek April 6, 2021 05:24

elek approved these changes Apr 6, 2021

View reviewed changes

jojochuang merged commit f608cda into apache:trunk Apr 7, 2021

asfgit pushed a commit that referenced this pull request Apr 7, 2021

HADOOP-17624. Remove any rocksdb exclusion code. (#2867)

4436524

Reviewed-by: Márton Elek <elek@apache.org> Reviewed-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit f608cda)

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021

HADOOP-17624. Remove any rocksdb exclusion code. (apache#2867)

3646abf

Reviewed-by: Márton Elek <elek@apache.org> Reviewed-by: Viraj Jasani <vjasani@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-17624. Remove any rocksdb exclusion code.#2867

HADOOP-17624. Remove any rocksdb exclusion code.#2867
jojochuang merged 3 commits intoapache:trunkfrom
jojochuang:remove_rocksdb

jojochuang commented Apr 6, 2021

Uh oh!

virajjasani left a comment

Uh oh!

hadoop-yetus commented Apr 6, 2021

Uh oh!

hadoop-yetus commented Apr 6, 2021

Uh oh!

elek left a comment

Uh oh!

jojochuang commented Apr 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jojochuang commented Apr 6, 2021

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Apr 6, 2021

Uh oh!

hadoop-yetus commented Apr 6, 2021

Uh oh!

elek left a comment

Choose a reason for hiding this comment

Uh oh!

jojochuang commented Apr 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants