HADOOP-17622. Avoid usage of deprecated IOUtils#cleanup API. by virajjasani · Pull Request #2862 · apache/hadoop

virajjasani · 2021-04-04T13:12:42Z

No description provided.

hadoop-yetus · 2021-04-04T21:26:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 35s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 1s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 44 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 17s		Maven dependency ordering for branch
+1 💚	mvninstall	20m 9s		trunk passed
+1 💚	compile	20m 42s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	18m 9s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	4m 0s		trunk passed
+1 💚	mvnsite	5m 16s		trunk passed
+1 💚	javadoc	4m 8s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	5m 13s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	8m 44s		trunk passed
+1 💚	shadedclient	14m 31s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 24s		the patch passed
+1 💚	compile	20m 13s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	20m 13s		root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 0 new + 1941 unchanged - 98 fixed = 1941 total (was 2039)
+1 💚	compile	18m 2s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	18m 2s		root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~~20.04-b08 generated 0 new + 1837 unchanged - 98 fixed = 1837 total (was 1935)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	3m 57s	/results-checkstyle-root.txt	root: The patch generated 3 new + 1680 unchanged - 0 fixed = 1683 total (was 1680)
+1 💚	mvnsite	5m 19s		the patch passed
+1 💚	javadoc	4m 12s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	5m 11s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	9m 24s		the patch passed
+1 💚	shadedclient	14m 21s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 25s		hadoop-common in the patch passed.
-1 ❌	unit	231m 47s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	unit	19m 39s		hadoop-distcp in the patch passed.
+1 💚	unit	1m 0s		hadoop-rumen in the patch passed.
+1 💚	unit	16m 6s		hadoop-gridmix in the patch passed.
+1 💚	asflicense	1m 12s		The patch does not generate ASF License warnings.
		492m 15s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
	hadoop.hdfs.server.balancer.TestBalancer
	hadoop.hdfs.server.datanode.TestBlockRecovery
	hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2862/1/artifact/out/Dockerfile
GITHUB PR	#2862
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux f1f94388b981 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 2bafcbcbbb5f71a8d20ab48d7f21f4a2a74b7dcc
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2862/1/testReport/
Max. process+thread count	3741 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-distcp hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2862/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

virajjasani · 2021-04-05T09:01:32Z

Would you like to take a look @tasanuma ?
Thanks

tasanuma · 2021-04-05T09:53:30Z

LGTM, pending Jenkins.

hadoop-yetus · 2021-04-05T17:14:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 42s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 2s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 44 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 22s		Maven dependency ordering for branch
+1 💚	mvninstall	20m 15s		trunk passed
+1 💚	compile	20m 44s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	18m 6s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	4m 7s		trunk passed
+1 💚	mvnsite	5m 22s		trunk passed
+1 💚	javadoc	4m 14s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	5m 15s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	8m 37s		trunk passed
+1 💚	shadedclient	14m 28s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 25s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 25s		the patch passed
+1 💚	compile	20m 9s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	20m 9s		root-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 0 new + 1941 unchanged - 98 fixed = 1941 total (was 2039)
+1 💚	compile	18m 15s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	18m 15s		root-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~~20.04-b08 generated 0 new + 1837 unchanged - 98 fixed = 1837 total (was 1935)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	3m 55s		the patch passed
+1 💚	mvnsite	5m 21s		the patch passed
+1 💚	javadoc	4m 11s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	5m 18s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	9m 31s		the patch passed
+1 💚	shadedclient	14m 40s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 29s		hadoop-common in the patch passed.
-1 ❌	unit	230m 9s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	unit	19m 55s		hadoop-distcp in the patch passed.
+1 💚	unit	0m 58s		hadoop-rumen in the patch passed.
+1 💚	unit	16m 29s		hadoop-gridmix in the patch passed.
+1 💚	asflicense	1m 11s		The patch does not generate ASF License warnings.
		492m 18s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.datanode.TestBPOfferService
	hadoop.hdfs.server.datanode.TestBlockRecovery
	hadoop.hdfs.TestDecommissionWithStripedBackoffMonitor
	hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
	hadoop.hdfs.TestRollingUpgrade
	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2862/2/artifact/out/Dockerfile
GITHUB PR	#2862
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 38ca88720f5e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `6f55756`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2862/2/testReport/
Max. process+thread count	3469 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-distcp hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2862/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

tasanuma

The failed tests are passed in my local environment. +1.

tasanuma · 2021-04-06T04:39:26Z

Merged. Thanks for your contribution, @virajjasani!

Signed-off-by: Takanobu Asanuma <tasanuma@apache.org> (cherry picked from commit 3f2682b)

…2862) Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>

HADOOP-17622. Avoid usage of deprecated IOUtils#cleanup API.

6f55756

virajjasani force-pushed the HADOOP-17622-trunk branch from 2bafcbc to 6f55756 Compare April 5, 2021 09:00

tasanuma approved these changes Apr 6, 2021

View reviewed changes

tasanuma merged commit 3f2682b into apache:trunk Apr 6, 2021

tasanuma pushed a commit that referenced this pull request Apr 6, 2021

HADOOP-17622. Avoid usage of deprecated IOUtils#cleanup API. (#2862)

8b4b3d6

Signed-off-by: Takanobu Asanuma <tasanuma@apache.org> (cherry picked from commit 3f2682b)

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021

HADOOP-17622. Avoid usage of deprecated IOUtils#cleanup API. (apache#…

678949e

…2862) Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-17622. Avoid usage of deprecated IOUtils#cleanup API.#2862

HADOOP-17622. Avoid usage of deprecated IOUtils#cleanup API.#2862
tasanuma merged 1 commit intoapache:trunkfrom
virajjasani:HADOOP-17622-trunk

virajjasani commented Apr 4, 2021

Uh oh!

hadoop-yetus commented Apr 4, 2021

Uh oh!

virajjasani commented Apr 5, 2021

Uh oh!

tasanuma commented Apr 5, 2021

Uh oh!

hadoop-yetus commented Apr 5, 2021

Uh oh!

tasanuma left a comment

Uh oh!

tasanuma commented Apr 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

virajjasani commented Apr 4, 2021

Uh oh!

hadoop-yetus commented Apr 4, 2021

Uh oh!

virajjasani commented Apr 5, 2021

Uh oh!

tasanuma commented Apr 5, 2021

Uh oh!

hadoop-yetus commented Apr 5, 2021

Uh oh!

tasanuma left a comment

Choose a reason for hiding this comment

Uh oh!

tasanuma commented Apr 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants