HDFS-15621. Datanode DirectoryScanner uses excessive memory #2849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
The spotbugs warning looks like a false positive to me. |
jojochuang
reviewed
Apr 13, 2021
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
Patch looks reasonable to me. Thanks for working on this @sodonnel !
Just a little suggestion for javadoc
| * | ||
| * @param blockId the block ID | ||
| * @param blockFile the path to the block data file | ||
| * @param metaFile the path to the block meta-data file |
Contributor
There was a problem hiding this comment.
need a @param for basePath. Also add that metaFile stores only the suffix.
.../hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsVolumeSpi.java
Show resolved
Hide resolved
Contributor
Author
|
@jojochuang Thanks for the review - I have pushed a new commit with the change. Please have a look when you get a chance. |
|
💔 -1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Apr 26, 2021
…Contributed by Stephen O'Donnell (cherry picked from commit 605ed85) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
asfgit
pushed a commit
that referenced
this pull request
Apr 26, 2021
…Contributed by Stephen O'Donnell (cherry picked from commit 605ed85) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java (cherry picked from commit f6efb58) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsVolumeSpi.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDirectoryScanner.java
asfgit
pushed a commit
that referenced
this pull request
Apr 26, 2021
…Contributed by Stephen O'Donnell (cherry picked from commit 605ed85) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java (cherry picked from commit f6efb58) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsVolumeSpi.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDirectoryScanner.java (cherry picked from commit 7a81e50)
jojochuang
pushed a commit
to jojochuang/hadoop
that referenced
this pull request
May 23, 2023
). Contributed by Stephen O'Donnell (cherry picked from commit 605ed85) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java (cherry picked from commit f6efb58) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsVolumeSpi.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDirectoryScanner.java (cherry picked from commit 7a81e50) (cherry picked from commit 71a9885) Change-Id: I0974bdb6d05f8bd7741071b855ffce4389be969a (cherry picked from commit 97cfe8d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively simple change to reduce the memory used by the Directory Scanner and also simplify the logic in the ScanInfo object.
This change ensures the same File object is re-used for all blocks in a directory. Previously a large part of the path was repeated for each block file.
Aside from that, the logic of the directory scanner remains the same.
Comparing heap dumps, the memory used by 100K blocks goes from ~35MB to 19MB. Or 350MB per 1M blocks down to 190MB per 1M blocks. This is a reduction of about 46%.