HDFS-15936.Solve BlockSender#sendPacket() does not record SocketTimeout exception.#2836
Merged
jojochuang merged 1 commit intoapache:trunkfrom Jul 29, 2021
Merged
Conversation
virajjasani
reviewed
Mar 30, 2021
Contributor
virajjasani
left a comment
virajjasani
left a comment
There was a problem hiding this comment.
Left minor nit, looks good otherwise
Contributor
There was a problem hiding this comment.
nit: LOG.warn("Sending packets timed out.", e);
Member
There was a problem hiding this comment.
I am fine with the update though the exception would be threw and processed in DataXceiver#run.
|
💔 -1 overall
This message was automatically generated. |
…SocketTimeout exception.
Contributor
Author
|
@virajjasani, @cxorm , thank you for your attention. |
jianghuazhu
changed the title
|
💔 -1 overall
This message was automatically generated. |
Member
|
Thanks @jianghuazhu for the work and @virajjasani for the review. |
cxorm
approved these changes
Apr 8, 2021
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@cxorm , thank you very much for your work. Can this pr be merged into the trunk branch? If there is still a lack of other work, I am willing to contribute. |
Contributor
|
Merging it per Viraj and cxorm's review. |
kiran-maturi
pushed a commit
to kiran-maturi/hadoop
that referenced
this pull request
Nov 24, 2021
…SocketTimeout exception. (apache#2836) Co-authored-by: zhujianghua <zhujianghua@zhujianghuadeMacBook-Pro.local> Reviewed-by: cxorm <lianp964@gmail.com> Reviewed-by: Viraj Jasani <vjasani@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…SocketTimeout exception.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute