HDFS-15929. Replace RAND_pseudo_bytes in util.cc #2826

GauthamBanasandra · 2021-03-28T09:06:36Z

RAND_pseudo_bytes is deprecated in OpenSSL
1.1.1 and must be replaced by RAND_bytes.
Refactored usages of GetRandomClientName where
it now returns the client name wrapped in a
a shared_ptr to provide the ability to do
null check. We use a null check as a means to
get the functionality similar to monads in
functional programming.

hadoop-yetus · 2021-03-28T11:10:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 33s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 30s		trunk passed
+1 💚	compile	2m 41s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	2m 42s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	mvnsite	0m 31s		trunk passed
+1 💚	shadedclient	53m 7s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 15s		the patch passed
+1 💚	compile	2m 30s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
-1 ❌	cc	2m 30s	/results-compile-cc-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt	hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 3 new + 51 unchanged - 9 fixed = 54 total (was 60)
+1 💚	golang	2m 30s		the patch passed
+1 💚	javac	2m 30s		the patch passed
+1 💚	compile	2m 33s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	cc	2m 33s		hadoop-hdfs-project_hadoop-hdfs-native-client-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~~20.04-b08 generated 0 new + 54 unchanged - 6 fixed = 54 total (was 60)
+1 💚	golang	2m 33s		the patch passed
+1 💚	javac	2m 33s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-tabs.txt	The patch 2 line(s) with tabs.
+1 💚	mvnsite	0m 20s		the patch passed
+1 💚	shadedclient	13m 46s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	47m 19s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 34s		The patch does not generate ASF License warnings.
		123m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2826/1/artifact/out/Dockerfile
GITHUB PR	#2826
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell golang
uname	Linux 2f0bd0e78023 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 34533fdaf0132c638cc2ed6938cf86bd0aa34a6b
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2826/1/testReport/
Max. process+thread count	535 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2826/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-03-28T11:15:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 32s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 32s		trunk passed
+1 💚	compile	2m 43s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	2m 44s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	mvnsite	0m 25s		trunk passed
+1 💚	shadedclient	53m 20s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 16s		the patch passed
+1 💚	compile	2m 36s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
-1 ❌	cc	2m 36s	/results-compile-cc-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt	hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 3 new + 51 unchanged - 9 fixed = 54 total (was 60)
+1 💚	golang	2m 36s		the patch passed
+1 💚	javac	2m 36s		the patch passed
+1 💚	compile	2m 33s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	cc	2m 33s		hadoop-hdfs-project_hadoop-hdfs-native-client-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~~20.04-b08 generated 0 new + 54 unchanged - 6 fixed = 54 total (was 60)
+1 💚	golang	2m 33s		the patch passed
+1 💚	javac	2m 33s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-tabs.txt	The patch 2 line(s) with tabs.
+1 💚	mvnsite	0m 16s		the patch passed
+1 💚	shadedclient	13m 17s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	46m 33s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 33s		The patch does not generate ASF License warnings.
		122m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2826/2/artifact/out/Dockerfile
GITHUB PR	#2826
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell golang
uname	Linux f03230b8c966 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / ad532f6f47643f7270c089dd31a9b03b265db987
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2826/2/testReport/
Max. process+thread count	730 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2826/2/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-03-28T13:33:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 35s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 37s		trunk passed
+1 💚	compile	2m 39s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	2m 45s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	mvnsite	0m 29s		trunk passed
+1 💚	shadedclient	53m 15s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 15s		the patch passed
+1 💚	compile	2m 34s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
-1 ❌	cc	2m 34s	/results-compile-cc-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt	hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 7 new + 47 unchanged - 13 fixed = 54 total (was 60)
+1 💚	golang	2m 34s		the patch passed
+1 💚	javac	2m 34s		the patch passed
+1 💚	compile	2m 34s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
-1 ❌	cc	2m 34s	/results-compile-cc-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt	hadoop-hdfs-project_hadoop-hdfs-native-client-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~~20.04-b08 generated 6 new + 48 unchanged - 12 fixed = 54 total (was 60)
+1 💚	golang	2m 34s		the patch passed
+1 💚	javac	2m 34s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 20s		the patch passed
+1 💚	shadedclient	13m 50s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	41m 18s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 34s		The patch does not generate ASF License warnings.
		117m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2826/3/artifact/out/Dockerfile
GITHUB PR	#2826
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell golang
uname	Linux 320e2a3702eb 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 26ab61c5c03a3551bc0659a6b4d257d0cc4f1514
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2826/3/testReport/
Max. process+thread count	579 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2826/3/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

GauthamBanasandra · 2021-03-29T14:48:19Z

This PR fixes some warnings reported as part of #2792.

goiri · 2021-03-29T17:24:02Z

How come we still see:

[WARNING] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-2826/src/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/rpc/rpc_engine.cc:126:40: warning: 'int RAND_pseudo_bytes(unsigned char*, int)' is deprecated [-Wdeprecated-declarations]
[WARNING]                  from /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-2826/src/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/rpc/rpc_engine.cc:18:
[WARNING] /usr/include/openssl/rand.h:44:1: note: declared here
[WARNING] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-2826/src/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/rpc/rpc_engine.cc:126:40: warning: 'int RAND_pseudo_bytes(unsigned char*, int)' is deprecated [-Wdeprecated-declarations]
[WARNING]                  from /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-2826/src/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/rpc/rpc_engine.cc:18:
[WARNING] /usr/include/openssl/rand.h:44:1: note: declared here

GauthamBanasandra · 2021-03-29T17:39:24Z

[WARNING] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-2826/src/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/rpc/rpc_engine.cc:126:40: warning: 'int RAND_pseudo_bytes(unsigned char*, int)' is deprecated [-Wdeprecated-declarations]
[WARNING]                  from /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-2826/src/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/rpc/rpc_engine.cc:18:
[WARNING] /usr/include/openssl/rand.h:44:1: note: declared here

@goiri the above warnings are fixed in this PR - #2825. I created a separate PR for replacing each instance of RAND_pseudo_bytes since they involve quite a bit of refactoring and didn't want to complicate the PR review process.

hadoop-yetus · 2021-03-29T19:40:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 35s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 19s		trunk passed
+1 💚	compile	2m 39s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	2m 52s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	mvnsite	0m 29s		trunk passed
+1 💚	shadedclient	52m 54s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 16s		the patch passed
+1 💚	compile	2m 47s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
-1 ❌	cc	2m 47s	/results-compile-cc-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt	hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 6 new + 40 unchanged - 12 fixed = 46 total (was 52)
+1 💚	golang	2m 47s		the patch passed
+1 💚	javac	2m 47s		the patch passed
+1 💚	compile	2m 44s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
-1 ❌	cc	2m 44s	/results-compile-cc-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt	hadoop-hdfs-project_hadoop-hdfs-native-client-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~~20.04-b08 generated 6 new + 40 unchanged - 12 fixed = 46 total (was 52)
+1 💚	golang	2m 44s		the patch passed
+1 💚	javac	2m 44s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 19s		the patch passed
+1 💚	shadedclient	14m 14s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	32m 56s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 32s		The patch does not generate ASF License warnings.
		109m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2826/4/artifact/out/Dockerfile
GITHUB PR	#2826
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell golang
uname	Linux 76eaf2a8d44d 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / eb4abff06be2cf3bd5094f770c8c7bd2cfb9e3e1
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2826/4/testReport/
Max. process+thread count	650 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2826/4/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

* RAND_pseudo_bytes is deprecated in OpenSSL 1.1.1 and must be replaced by RAND_bytes. * Refactored usages of GetRandomClientName where it now returns the client name wrapped in a a shared_ptr to provide the ability to do null check. We use a null check as a means to get the functionality similar to monads in functional programming.

* Remove an extra tab to stick to an indentation of 2 characters.

* Removed blank tabs as reported by CI.

hadoop-yetus · 2021-03-30T19:48:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 20s		trunk passed
+1 💚	compile	2m 38s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	2m 44s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	mvnsite	0m 29s		trunk passed
+1 💚	shadedclient	51m 37s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 16s		the patch passed
+1 💚	compile	2m 29s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	cc	2m 29s		hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 0 new + 40 unchanged - 6 fixed = 40 total (was 46)
+1 💚	golang	2m 29s		the patch passed
+1 💚	javac	2m 29s		the patch passed
+1 💚	compile	2m 31s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	cc	2m 31s		hadoop-hdfs-project_hadoop-hdfs-native-client-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~~20.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~~20.04-b08 generated 0 new + 40 unchanged - 6 fixed = 40 total (was 46)
+1 💚	golang	2m 31s		the patch passed
+1 💚	javac	2m 31s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 18s		the patch passed
+1 💚	shadedclient	13m 2s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	31m 59s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 33s		The patch does not generate ASF License warnings.
		105m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2826/5/artifact/out/Dockerfile
GITHUB PR	#2826
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell golang
uname	Linux f884c103d0df 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `6befd42`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2826/5/testReport/
Max. process+thread count	626 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2826/5/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

goiri approved these changes Mar 29, 2021

View reviewed changes

GauthamBanasandra force-pushed the fix-rand-bytes-2 branch from 26ab61c to eb4abff Compare March 29, 2021 17:49

GauthamBanasandra added 3 commits March 30, 2021 23:30

Remove extra tab

8e1cd80

* Remove an extra tab to stick to an indentation of 2 characters.

Remove blank tabs

6befd42

* Removed blank tabs as reported by CI.

GauthamBanasandra force-pushed the fix-rand-bytes-2 branch from eb4abff to 6befd42 Compare March 30, 2021 18:01

goiri merged commit 7dfff49 into apache:trunk Mar 30, 2021

GauthamBanasandra deleted the fix-rand-bytes-2 branch July 30, 2021 12:05

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021

HDFS-15929. Replace RAND_pseudo_bytes in util.cc (apache#2826)

1a81a0b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-15929. Replace RAND_pseudo_bytes in util.cc #2826

HDFS-15929. Replace RAND_pseudo_bytes in util.cc #2826

Uh oh!

GauthamBanasandra commented Mar 28, 2021

Uh oh!

hadoop-yetus commented Mar 28, 2021

Uh oh!

hadoop-yetus commented Mar 28, 2021

Uh oh!

hadoop-yetus commented Mar 28, 2021

Uh oh!

GauthamBanasandra commented Mar 29, 2021

Uh oh!

goiri commented Mar 29, 2021

Uh oh!

GauthamBanasandra commented Mar 29, 2021

Uh oh!

hadoop-yetus commented Mar 29, 2021

Uh oh!

hadoop-yetus commented Mar 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HDFS-15929. Replace RAND_pseudo_bytes in util.cc #2826

HDFS-15929. Replace RAND_pseudo_bytes in util.cc #2826

Uh oh!

Conversation

GauthamBanasandra commented Mar 28, 2021

Uh oh!

hadoop-yetus commented Mar 28, 2021

Uh oh!

hadoop-yetus commented Mar 28, 2021

Uh oh!

hadoop-yetus commented Mar 28, 2021

Uh oh!

GauthamBanasandra commented Mar 29, 2021

Uh oh!

goiri commented Mar 29, 2021

Uh oh!

GauthamBanasandra commented Mar 29, 2021

Uh oh!

hadoop-yetus commented Mar 29, 2021

Uh oh!

hadoop-yetus commented Mar 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants