Skip to content

HDFS-15884. RBF: Remove unused method getCreateLocation in RouterRpcS… #2754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ayushtkn merged 1 commit into from
Mar 13, 2021
Merged

HDFS-15884. RBF: Remove unused method getCreateLocation in RouterRpcS… #2754

ayushtkn merged 1 commit into from
Mar 13, 2021

Conversation

@tomscut
Copy link
Contributor

@tomscut tomscut commented Mar 9, 2021 •
edited
Loading

JIRA: HDFS-15884

Remove unused method org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer#getCreateLocation.

@tomscut
Copy link
Contributor Author

tomscut commented Mar 11, 2021

Hi @ayushtkn , can we remove this method org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer#getCreateLocation?

ayushtkn
ayushtkn reviewed Mar 11, 2021
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be yes, if it isn't used anywhere, The build isn't happy, can you rebase and push again?
If things are good post that we can push this

@tomscut
Copy link
Contributor Author

tomscut commented Mar 12, 2021

Should be yes, if it isn't used anywhere, The build isn't happy, can you rebase and push again?
If things are good post that we can push this

Thanks @ayushtkn for the review, I rebased and pushed again.

@tomscut
Copy link
Contributor Author

tomscut commented Mar 12, 2021

Failed junit tests
hadoop.hdfs.server.federation.router.TestConnectionManager

This failed unit tests is unrelated to the change, and it works fine locally.

ayushtkn
ayushtkn approved these changes Mar 13, 2021
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM,
I have triggered the build once again, hopefully we might get a green build.
Will commit by tomorrow if no objections.

@ayushtkn ayushtkn merged commit e565b05 into apache:trunk Mar 13, 2021
@tomscut
Copy link
Contributor Author

tomscut commented Mar 14, 2021

Changes LGTM,
I have triggered the build once again, hopefully we might get a green build.
Will commit by tomorrow if no objections.

Thanks @ayushtkn .

asfgit pushed a commit that referenced this pull request Apr 13, 2021
@ayushtkn
Revert "HDFS-15884. RBF: Remove unused method getCreateLocation in Ro…
7d6f0ca 
…uterRpcServer (#2754). Contributed by tomscut."

This reverts commit e565b05.

The removed method needs to be used in HDFS-15423.
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
@tomscut
HDFS-15884. RBF: Remove unused method getCreateLocation in RouterRpcS…
91bc0b0 
…erver (apache#2754). Contributed by tomscut.
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
@ayushtkn
Revert "HDFS-15884. RBF: Remove unused method getCreateLocation in Ro…
ecc67c5 
…uterRpcServer (apache#2754). Contributed by tomscut."

This reverts commit e565b05.

The removed method needs to be used in HDFS-15423.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ayushtkn ayushtkn ayushtkn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomscut @ayushtkn