HDFS-15865 Interrupt DataStreamer thread if no ack #2728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@karthikhw , the patch generally looks good to me, However what are the cases when the nodes is null ? |
Contributor
Author
|
@mukul1987 Not exactly found when nodes come null but appears when client couldn't reachable datenode (during middle of its write). Looks the next retry comes with null. |
sodonnel
reviewed
Apr 9, 2021
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java
Outdated
Show resolved
Hide resolved
sodonnel
reviewed
Apr 9, 2021
| newScope("waitForAckedSeqno")) { | ||
| LOG.debug("{} waiting for ack for: {}", this, seqno); | ||
| int dnodes = nodes != null ? nodes.length : 3; | ||
| int writeTimeout = dfsClient.getDatanodeWriteTimeout(dnodes); |
Contributor
There was a problem hiding this comment.
This timeout is very long. For a 3 node pipeline, it will be 8 minutes + 3 * 5 seconds (for the extension).
I'm not sure I have a better suggestion for the timeout.
One question - I believe we saw this problem in a Hung Hive Server 2 process. Do we know how this problem causes the entire HS2 instance to get hung? I would have thought this issue would block the closing of a single file on HDFS and other files open within the same client could still progress as normal?
Contributor
Author
There was a problem hiding this comment.
Not much troubleshooting in Hive @sodonnel. It looks whole HS2 instance was hung. It didn't accept any new connections.
Contributor
There was a problem hiding this comment.
Thanks - I guess we can go ahead with this change, but even with it, the HS2 may well get hung for 8+ minutes. Its hard to know for sure without knowing why this problem caused the whole instance to hang.
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
Thanks for the review @sodonnel , merging this. |
asfgit
pushed a commit
that referenced
this pull request
May 4, 2021
(cherry picked from commit bd3da73)
kiran-maturi
pushed a commit
to kiran-maturi/hadoop
that referenced
this pull request
Nov 24, 2021
jojochuang
pushed a commit
to jojochuang/hadoop
that referenced
this pull request
May 23, 2023
(cherry picked from commit bd3da73) Change-Id: I6604bb34e01b2e13ee4a8aafc54dc5126850fd00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.