HDFS-15862. Make TestViewfsWithNfs3.testNfsRenameSingleNN() idempotent #2724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
aajisaka
requested changes
Aug 30, 2021
Member
aajisaka
left a comment
aajisaka
left a comment
There was a problem hiding this comment.
If the 2nd rename failed, the test will be non-idempotent. I think renameSingleNN should be created in the test case instead of @BeforeClass. In addition, we need to remove renameSingleNNSucess if exists before running rename.
Contributor
Author
|
@aajisaka Thanks for the feedback! I've made the corresponding changes following your suggestion. Please let me know what you think. Thanks! |
|
🎊 +1 overall
This message was automatically generated. |
aajisaka
reviewed
Sep 1, 2021
...roject/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestViewfsWithNfs3.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
aajisaka
approved these changes
Dec 8, 2021
aajisaka
changed the title
Member
|
Merged. Thank you @lzx404243 |
aajisaka
pushed a commit
that referenced
this pull request
Dec 8, 2021
#2724) Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit 7ba91c1)
aajisaka
pushed a commit
that referenced
this pull request
Dec 8, 2021
#2724) Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit 7ba91c1)
sunchao
pushed a commit
that referenced
this pull request
Jan 4, 2022
#2724) Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit 7ba91c1)
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
apache#2724) Signed-off-by: Akira Ajisaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
org.apache.hadoop.hdfs.nfs.nfs3.TestViewfsWithNfs3.testNfsRenameSingleNNis not idempotent and fails if run twice in the same JVM, because it pollutes state shared among tests. It may be good to clean this state pollution so that some other tests do not fail in the future due to the shared state polluted by this test.Details
Running
TestViewfsWithNfs3.testNfsRenameSingleNNtwice would result in the second run failing with the a NullPointer exception:The reason for this is that the
/user1/renameSingleNNfile is created insetup(), but gets renamed intestNfsRenameSingleNN. When the second run oftestNfsRenameSingleNNtries to get info of the file by its original name, it returns a NullPointer since the file no longer exists.The fix for this is to rename the file back to the original when the test is done.
With the proposed fix, the test does not pollute the shared state (and passes when run twice in the same JVM).
Link to JIRA issue: https://issues.apache.org/jira/browse/HDFS-15862