HDFS-15830. Support to make dfs.image.parallel.load reconfigurable #2694

ferhui · 2021-02-09T09:21:28Z

NOTICE

Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

hadoop-yetus · 2021-02-09T14:38:39Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 35s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	36m 16s		trunk passed
+1 💚	compile	1m 28s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 21s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	checkstyle	1m 12s		trunk passed
+1 💚	mvnsite	1m 26s		trunk passed
+1 💚	shadedclient	18m 59s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 59s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 30s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+0 🆗	spotbugs	3m 41s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 39s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 21s		the patch passed
+1 💚	compile	1m 17s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javac	1m 17s		the patch passed
+1 💚	compile	1m 9s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	javac	1m 9s		the patch passed
-0 ⚠️	checkstyle	1m 6s	/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 374 unchanged - 0 fixed = 376 total (was 374)
+1 💚	mvnsite	1m 18s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	15m 55s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 54s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 22s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	findbugs	3m 28s		the patch passed
			_ Other Tests _
-1 ❌	unit	217m 38s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		316m 4s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.balancer.TestBalancer
	hadoop.hdfs.tools.TestDFSAdmin

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2694/1/artifact/out/Dockerfile
GITHUB PR	#2694
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 5cec89c80b05 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `2df2dfb`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2694/1/testReport/
Max. process+thread count	2246 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2694/1/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-02-13T17:31:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 13s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 34s		trunk passed
+1 💚	compile	1m 21s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 11s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 4s		trunk passed
+1 💚	mvnsite	1m 24s		trunk passed
+1 💚	shadedclient	18m 22s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 53s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 19s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗	spotbugs	3m 14s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 12s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 11s		the patch passed
+1 💚	compile	1m 14s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	1m 13s		the patch passed
+1 💚	compile	1m 7s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	1m 7s		the patch passed
+1 💚	checkstyle	0m 59s		the patch passed
+1 💚	mvnsite	1m 13s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	15m 9s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 48s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 18s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	findbugs	3m 16s		the patch passed
			_ Other Tests _
-1 ❌	unit	215m 56s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 36s		The patch does not generate ASF License warnings.
		308m 25s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestRollingUpgrade

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2694/2/artifact/out/Dockerfile
GITHUB PR	#2694
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux f18270b498fb 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `f9a073c`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2694/2/testReport/
Max. process+thread count	2373 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2694/2/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

dineshchitlangia

LGTM @ferhui , test failure is unrelated to patch

ferhui · 2021-02-15T08:59:48Z

@dineshchitlangia Thanks for review!
Wait until @sodonnel take another look.

sodonnel

Changes LGTM. Sorry for the slow review!

Can you commit to trunk and then cherry pick to branch-3.3 (assuming the cherry-pick is clean and it compiles OK)?

ferhui · 2021-02-19T01:07:00Z

@sodonnel @dineshchitlangia Thanks for review !
merged to trunk

…2694)

ferhui · 2021-02-19T01:30:56Z

cherry-picked to branch-3.3

…pache#2694)

…figurable (apache#2694)

HDFS-15830. Support to make dfs.image.parallel.load reconfigurable

109040e

fix UT & checkstyle

5b0e457

dineshchitlangia approved these changes Feb 14, 2021

View reviewed changes

sodonnel approved these changes Feb 18, 2021

View reviewed changes

ferhui merged commit 2970bd9 into apache:trunk Feb 19, 2021

ferhui deleted the HDFS-15830 branch February 19, 2021 01:07

asfgit pushed a commit that referenced this pull request Feb 19, 2021

HDFS-15830. Support to make dfs.image.parallel.load reconfigurable (#…

a9d3500

…2694)

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021

HDFS-15830. Support to make dfs.image.parallel.load reconfigurable (a…

e84c720

…pache#2694)

Xushaohong pushed a commit to Xushaohong/hadoop that referenced this pull request Jul 20, 2022

THADOOP-123 HDFS-15830. Support to make dfs.image.parallel.load recon…

94887fd

…figurable (apache#2694)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-15830. Support to make dfs.image.parallel.load reconfigurable #2694

HDFS-15830. Support to make dfs.image.parallel.load reconfigurable #2694

Uh oh!

ferhui commented Feb 9, 2021

Uh oh!

hadoop-yetus commented Feb 9, 2021

Uh oh!

hadoop-yetus commented Feb 13, 2021

Uh oh!

dineshchitlangia left a comment •

edited

Loading

Uh oh!

ferhui commented Feb 15, 2021

Uh oh!

sodonnel left a comment

Uh oh!

ferhui commented Feb 19, 2021

Uh oh!

ferhui commented Feb 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HDFS-15830. Support to make dfs.image.parallel.load reconfigurable #2694

HDFS-15830. Support to make dfs.image.parallel.load reconfigurable #2694

Uh oh!

Conversation

ferhui commented Feb 9, 2021

NOTICE

Uh oh!

hadoop-yetus commented Feb 9, 2021

Uh oh!

hadoop-yetus commented Feb 13, 2021

Uh oh!

dineshchitlangia left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ferhui commented Feb 15, 2021

Uh oh!

sodonnel left a comment

Choose a reason for hiding this comment

Uh oh!

ferhui commented Feb 19, 2021

Uh oh!

ferhui commented Feb 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dineshchitlangia left a comment •

edited

Loading