HADOOP-15710. ABFS checkException to map 403 to AccessDeniedException.#2648
Merged
steveloughran merged 4 commits intoapache:trunkfrom Feb 2, 2021
Merged
Conversation
This maps both 401 and 403 to AccessDeniedException. The test does not work, because even though I'm removing permissions from the file and parent dir, it's still opening. Change-Id: Ieb65eb6bb057085b312fb1582eaf65c55ef2e634
mehakmeet
reviewed
Jan 28, 2021
Contributor
mehakmeet
left a comment
mehakmeet
left a comment
There was a problem hiding this comment.
production code looks good but the test might need another commit as mentioned by you above.
...adoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsRestOperationException.java
Outdated
Show resolved
Hide resolved
...adoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsRestOperationException.java
Outdated
Show resolved
Hide resolved
Change-Id: I5fa1a1f5da7f581bd22571f2ce1f1c8e5b896398
Contributor
Author
|
Updated with the other place this exception is looked for. But I don't have the auth setup to run those tests (I need to spend another few hours trying to get them). The new test is failing, that is, I can remove permissions from a file and then read the results. That shouldn't happen unless those permissions aren't actually being enforced on my store |
Change-Id: I55f45d7bdb2861b21a96ae19699da64438921abf
Contributor
Author
|
logs from failure of latest code |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
Yes, pretty weird that you can still read the file with no permissions, maybe add to see if the permissions are actually getting set or not too. Edit: I added this before intercept() and got "---------" returned. |
Needed to make the translation method static and package scoped Change-Id: I1120bac9d271f224ef117d49ce82fd61e91e8149
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
UT's is good option here. +1. |
Contributor
Author
|
thanks. merging. |
asfgit
pushed a commit
that referenced
this pull request
Feb 2, 2021
#2648) When 403 is returned from an ABFS HTTP call, an AccessDeniedException is raised. The exception text is unchanged, for any application string matching on the getMessage() contents. Contributed by Steve Loughran. Change-Id: I519d50ccd657968fd8ee72d132518099de901e15
jojochuang
pushed a commit
to jojochuang/hadoop
that referenced
this pull request
May 23, 2023
…iedException. (apache#2648) When 403 is returned from an ABFS HTTP call, an AccessDeniedException is raised. The exception text is unchanged, for any application string matching on the getMessage() contents. Contributed by Steve Loughran. Change-Id: I519d50ccd657968fd8ee72d132518099de901e15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This maps both 401 and 403 to AccessDeniedException.
The test does not work, because even though I'm removing permissions
from the file and parent dir, it's still opening.
Tested: Azure cardiff