Skip to content

HADOOP-17432. [JDK 16] KerberosUtil#getOidInstance is broken by JEP 396#2546

Merged
aajisaka merged 4 commits intoapache:trunkfrom
aajisaka:HADOOP-17432
Feb 5, 2021
Merged

HADOOP-17432. [JDK 16] KerberosUtil#getOidInstance is broken by JEP 396#2546
aajisaka merged 4 commits intoapache:trunkfrom
aajisaka:HADOOP-17432

Conversation

@aajisaka
Copy link
Copy Markdown
Member

@aajisaka aajisaka commented Dec 14, 2020 •
edited
Loading

JIRA: https://issues.apache.org/jira/browse/HADOOP-17432

  • Removed the use of JDK internal APIs
  • Deprecated KerberosUtil#getOidInstance
  • Use the default OID in Hadoop

TestAltKerberosAuthenticationHandler passed in JDK 16-ea+28.

[INFO] Running org.apache.hadoop.security.authentication.server.TestAltKerberosAuthenticationHandler
[INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.761 s - in org.apache.hadoop.security.authentication.server.TestAltKerberosAuthenticationHandler

@hadoop-yetus
Copy link
Copy Markdown

hadoop-yetus commented Dec 14, 2020

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 13m 46s Maven dependency ordering for branch
+1 💚 mvninstall 21m 15s trunk passed
+1 💚 compile 20m 28s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 compile 17m 22s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 checkstyle 2m 40s trunk passed
+1 💚 mvnsite 2m 22s trunk passed
+1 💚 shadedclient 20m 52s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 2m 1s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 1m 54s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗 spotbugs 1m 9s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 3s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for patch
+1 💚 mvninstall 1m 23s the patch passed
+1 💚 compile 19m 17s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
-1 ❌ javac 19m 17s /diff-compile-javac-root-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt root-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 generated 2 new + 2043 unchanged - 0 fixed = 2045 total (was 2043)
+1 💚 compile 21m 15s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
-1 ❌ javac 21m 15s /diff-compile-javac-root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu118.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu118.04-b01 generated 2 new + 1939 unchanged - 0 fixed = 1941 total (was 1939)
-0 ⚠️ checkstyle 3m 13s /diff-checkstyle-root.txt root: The patch generated 12 new + 3 unchanged - 0 fixed = 15 total (was 3)
+1 💚 mvnsite 2m 9s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
-1 ❌ shadedclient 17m 26s patch has errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 40s /patch-javadoc-hadoop-common-project_hadoop-auth-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt hadoop-auth in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌ javadoc 0m 37s /patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt hadoop-yarn-client in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌ javadoc 0m 38s /patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services_hadoop-yarn-services-core-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt hadoop-yarn-services-core in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌ javadoc 0m 38s /patch-javadoc-hadoop-common-project_hadoop-auth-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt hadoop-auth in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
-1 ❌ javadoc 0m 38s /patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt hadoop-yarn-client in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
-1 ❌ javadoc 0m 40s /patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services_hadoop-yarn-services-core-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt hadoop-yarn-services-core in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
-1 ❌ findbugs 0m 37s /patch-findbugs-hadoop-common-project_hadoop-auth.txt hadoop-auth in the patch failed.
-1 ❌ findbugs 0m 37s /patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt hadoop-yarn-client in the patch failed.
-1 ❌ findbugs 0m 37s /patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services_hadoop-yarn-services-core.txt hadoop-yarn-services-core in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 39s /patch-unit-hadoop-common-project_hadoop-auth.txt hadoop-auth in the patch failed.
-1 ❌ unit 0m 38s /patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt hadoop-yarn-client in the patch failed.
-1 ❌ unit 0m 39s /patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services_hadoop-yarn-services-core.txt hadoop-yarn-services-core in the patch failed.
+0 🆗 asflicense 0m 41s ASF License check generated no output?
180m 23s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2546/1/artifact/out/Dockerfile
GITHUB PR #2546
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 141445d893dd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 3234e5e
Default Java Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2546/1/testReport/
Max. process+thread count 538 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-auth hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2546/1/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link
Copy Markdown

hadoop-yetus commented Dec 14, 2020

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 0m 1s test4tests The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 13m 50s Maven dependency ordering for branch
+1 💚 mvninstall 28m 9s trunk passed
+1 💚 compile 24m 7s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 compile 17m 31s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 checkstyle 2m 40s trunk passed
+1 💚 mvnsite 2m 8s trunk passed
+1 💚 shadedclient 20m 0s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 51s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 1m 44s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗 spotbugs 1m 8s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 56s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for patch
+1 💚 mvninstall 1m 21s the patch passed
+1 💚 compile 19m 26s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javac 19m 26s the patch passed
+1 💚 compile 17m 21s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 javac 17m 21s the patch passed
+1 💚 checkstyle 2m 31s the patch passed
+1 💚 mvnsite 2m 9s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 45s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 37s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 1m 39s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 findbugs 3m 19s the patch passed
_ Other Tests _
+1 💚 unit 3m 14s hadoop-auth in the patch passed.
+1 💚 unit 26m 43s hadoop-yarn-client in the patch passed.
+1 💚 unit 19m 38s hadoop-yarn-services-core in the patch passed.
+1 💚 asflicense 0m 54s The patch does not generate ASF License warnings.
231m 12s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2546/4/artifact/out/Dockerfile
GITHUB PR #2546
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 4ae34bfa5b8a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 3234e5e
Default Java Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2546/4/testReport/
Max. process+thread count 836 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-auth hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2546/4/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@e1iu
Copy link
Copy Markdown

e1iu commented Feb 2, 2021 •
edited
Loading

Have you tried that if

export HADOOP_OPTS="--illegal-access=permit"
export YARN_OPTS="--illegal-access=permit"

could solve the problem as a workaround?
@aajisaka

@aajisaka
Copy link
Copy Markdown
Member Author

aajisaka commented Feb 2, 2021

@theRealELiu
I think the workaround works. However, it will force users/admins to set the --illegal-access=permit option to all the Hadoop applications, which is not ideal.

@e1iu
Copy link
Copy Markdown

e1iu commented Feb 2, 2021

Thanks for your explanation.

Do you know the release date of 3.3.1 or 3.4? And is there any plan to support java-17, it's a LTS version.

@aajisaka
Copy link
Copy Markdown
Member Author

aajisaka commented Feb 2, 2021

Do you know the release date of 3.3.1 or 3.4?

3.3.1 will be released soon. I don't know when 3.4 will be released.
https://lists.apache.org/thread.html/r7257d55d909dceced11203bf9519917f2ec43aa443d343199eed7f56%40%3Ccommon-dev.hadoop.apache.org%3E

And is there any plan to support java-17, it's a LTS version.

I want to support Java 17 by September 2021, when Java 17 will be released.

@e1iu
Copy link
Copy Markdown

e1iu commented Feb 2, 2021

Thanks, that's really a good news.

steveloughran
steveloughran requested changes Feb 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1; added a minor suggestion which would be nice to have in first

@hadoop-yetus
Copy link
Copy Markdown

hadoop-yetus commented Feb 5, 2021

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 0m 0s test4tests The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 2s Maven dependency ordering for branch
+1 💚 mvninstall 22m 3s trunk passed
+1 💚 compile 22m 28s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚 compile 19m 10s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚 checkstyle 3m 56s trunk passed
+1 💚 mvnsite 2m 0s trunk passed
+1 💚 shadedclient 19m 46s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 43s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 1m 33s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+0 🆗 spotbugs 1m 9s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 56s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for patch
+1 💚 mvninstall 1m 19s the patch passed
+1 💚 compile 22m 19s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚 javac 22m 19s the patch passed
+1 💚 compile 19m 28s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚 javac 19m 28s the patch passed
+1 💚 checkstyle 3m 47s the patch passed
+1 💚 mvnsite 2m 8s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 13m 52s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 36s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 1m 35s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚 findbugs 3m 20s the patch passed
_ Other Tests _
+1 💚 unit 3m 20s hadoop-auth in the patch passed.
+1 💚 unit 27m 34s hadoop-yarn-client in the patch passed.
+1 💚 unit 19m 55s hadoop-yarn-services-core in the patch passed.
+1 💚 asflicense 0m 46s The patch does not generate ASF License warnings.
230m 54s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2546/5/artifact/out/Dockerfile
GITHUB PR #2546
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux e7a3e84e5c7c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / b99dba3
Default Java Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2546/5/testReport/
Max. process+thread count 836 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-auth hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2546/5/console
versions git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@aajisaka aajisaka merged commit 52217fc into apache:trunk Feb 5, 2021
@aajisaka aajisaka deleted the HADOOP-17432 branch February 5, 2021 07:14
aajisaka added a commit that referenced this pull request Feb 5, 2021
@aajisaka
HADOOP-17432. [JDK 16] KerberosUtil#getOidInstance is broken by JEP 3…
bdd22b6 
…96 (#2546)

Reviewed-by: Steve Loughran <stevel@apache.org>
(cherry picked from commit 52217fc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steveloughran steveloughran steveloughran requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aajisaka @hadoop-yetus @e1iu @steveloughran