Skip to content

HDFS-15706. HttpFS: Log more information on request failures. #2515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jojochuang merged 2 commits into from
Dec 3, 2020
Merged

HDFS-15706. HttpFS: Log more information on request failures. #2515

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54a8cac
HDFS-15706. HttpFS: Log more information on request failures.
amahussein Dec 3, 2020
8196e91
HDFS-15706. parametrize debug.log
amahussein Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...p-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSExceptionProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,16 @@ public Response toResponse(Throwable throwable) {
status = Response.Status.NOT_FOUND;
} else if (throwable instanceof IOException) {
status = Response.Status.INTERNAL_SERVER_ERROR;
logErrorFully(status, throwable);
} else if (throwable instanceof UnsupportedOperationException) {
status = Response.Status.BAD_REQUEST;
logErrorFully(status, throwable);
} else if (throwable instanceof IllegalArgumentException) {
status = Response.Status.BAD_REQUEST;
logErrorFully(status, throwable);
} else {
status = Response.Status.INTERNAL_SERVER_ERROR;
logErrorFully(status, throwable);
}
return createResponse(status, throwable);
}
Expand All @@ -95,4 +99,7 @@ protected void log(Response.Status status, Throwable throwable) {
LOG.warn("[{}:{}] response [{}] {}", method, path, status, message, throwable);
}

private void logErrorFully(Response.Status status, Throwable throwable) {
LOG.debug("Failed with {}", status, throwable);
}
}