Skip to content

Conversation

@tucked
Copy link
Contributor

@tucked tucked commented Sep 18, 2020

Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
thanks for finding these. you were clearly doing the due diligence

@steveloughran steveloughran merged commit fc2435c into apache:trunk Sep 18, 2020
@steveloughran
Copy link
Contributor

Merged.

David, if you are getting into rename semantics know that nobody is confident enough about it to be certain about what happens in cases, we know HDFS gets it "wrong" in some. If you have spare time a review of #743 would be wonderful.

@tucked tucked deleted the HADOOP-15136 branch September 18, 2020 17:31
asfgit pushed a commit that referenced this pull request Sep 18, 2020
Contributed by David Tucker

Change-Id: I130e15d4f625a5b1b30967e6cfc1684079dd1f98
@steveloughran
Copy link
Contributor

Also: you got a login on the apache JIRA so I can assign/credit the issue there to you

@tucked
Copy link
Contributor Author

tucked commented Sep 18, 2020

If you have spare time a review of #743 would be wonderful.

Not sure if/how much I'll be able to help, but sure! I'll take a peek.

Also: you got a login on the apache JIRA so I can assign/credit the issue there to you

Yes, I'm also tucked on JIRA 😊

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 15s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 31m 20s trunk passed
+1 💚 mvnsite 1m 16s trunk passed
+1 💚 shadedclient 48m 22s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 51s the patch passed
+1 💚 mvnsite 1m 10s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 15m 34s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
69m 29s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2314/1/artifact/out/Dockerfile
GITHUB PR #2314
Optional Tests dupname asflicense mvnsite markdownlint
uname Linux 81b973723627 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2377df3
Max. process+thread count 337 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2314/1/console
versions git=2.17.1 maven=3.6.0
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

bilaharith pushed a commit to bilaharith/hadoop that referenced this pull request Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants