HADOOP-17222. Create socket address combined with URI cache #2241

1996fanrui · 2020-08-24T17:42:34Z

https://issues.apache.org/jira/browse/HADOOP-17222
Create socket address combined with cache to speed up hdfs client choose DataNode

hadoop-yetus · 2020-08-24T21:54:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	32m 17s	trunk passed
+1 💚	compile	24m 49s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	19m 59s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	0m 46s	trunk passed
+1 💚	mvnsite	1m 25s	trunk passed
+1 💚	shadedclient	17m 57s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 29s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 22s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	2m 21s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 19s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 53s	the patch passed
+1 💚	compile	20m 56s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	20m 56s	the patch passed
+1 💚	compile	17m 31s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	17m 31s	the patch passed
-0 ⚠️	checkstyle	0m 45s	hadoop-common-project/hadoop-common: The patch generated 7 new + 33 unchanged - 0 fixed = 40 total (was 33)
+1 💚	mvnsite	1m 22s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 40s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 27s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 23s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	2m 20s	the patch passed
		_ Other Tests _
-1 ❌	unit	9m 22s	hadoop-common in the patch passed.
+1 💚	asflicense	0m 45s	The patch does not generate ASF License warnings.
		176m 29s

Reason	Tests
Failed junit tests	hadoop.security.TestSecurityUtil

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/1/artifact/out/Dockerfile
GITHUB PR	#2241
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux f427c6771114 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `15a0fed`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/1/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/1/testReport/
Max. process+thread count	2472 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/1/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java

hadoop-yetus · 2020-08-25T05:48:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	29m 47s	trunk passed
+1 💚	compile	21m 13s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	17m 48s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	0m 47s	trunk passed
+1 💚	mvnsite	1m 30s	trunk passed
+1 💚	shadedclient	17m 5s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 34s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 31s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	2m 23s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 21s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 57s	the patch passed
+1 💚	compile	20m 21s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	20m 21s	the patch passed
+1 💚	compile	17m 44s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	17m 44s	the patch passed
-0 ⚠️	checkstyle	0m 46s	hadoop-common-project/hadoop-common: The patch generated 2 new + 32 unchanged - 1 fixed = 34 total (was 33)
+1 💚	mvnsite	1m 36s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	13m 54s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 29s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 31s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	2m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 32s	hadoop-common in the patch passed.
+1 💚	asflicense	0m 51s	The patch does not generate ASF License warnings.
		165m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/2/artifact/out/Dockerfile
GITHUB PR	#2241
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux ae8a45da1636 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `64f36b9`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/2/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/2/testReport/
Max. process+thread count	1430 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/2/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-08-25T06:25:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 44s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	35m 2s	trunk passed
+1 💚	compile	28m 13s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	21m 53s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	0m 46s	trunk passed
+1 💚	mvnsite	1m 23s	trunk passed
+1 💚	shadedclient	18m 10s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 30s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 24s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	2m 13s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 11s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 49s	the patch passed
+1 💚	compile	20m 10s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	20m 10s	the patch passed
+1 💚	compile	17m 31s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	17m 31s	the patch passed
-0 ⚠️	checkstyle	0m 45s	hadoop-common-project/hadoop-common: The patch generated 2 new + 32 unchanged - 1 fixed = 34 total (was 33)
+1 💚	mvnsite	1m 21s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 24s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 29s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 25s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	2m 21s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 50s	hadoop-common in the patch passed.
+1 💚	asflicense	0m 47s	The patch does not generate ASF License warnings.
		184m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/3/artifact/out/Dockerfile
GITHUB PR	#2241
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux bca38132d7d2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `64f36b9`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/3/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/3/testReport/
Max. process+thread count	3233 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/3/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-08-25T19:19:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	29m 8s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	3m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	26m 46s	trunk passed
+1 💚	compile	22m 50s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	20m 23s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	3m 1s	trunk passed
+1 💚	mvnsite	4m 22s	trunk passed
+1 💚	shadedclient	23m 19s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	2m 21s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	3m 54s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	2m 58s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	9m 3s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 30s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 5s	the patch passed
+1 💚	compile	23m 55s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	23m 55s	the patch passed
+1 💚	compile	19m 57s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	19m 57s	the patch passed
-0 ⚠️	checkstyle	2m 58s	root: The patch generated 1 new + 114 unchanged - 2 fixed = 115 total (was 116)
+1 💚	mvnsite	4m 5s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	shadedclient	16m 5s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	2m 22s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	3m 54s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	9m 27s	the patch passed
		_ Other Tests _
+1 💚	unit	10m 25s	hadoop-common in the patch passed.
+1 💚	unit	2m 23s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	103m 51s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 7s	The patch does not generate ASF License warnings.
		350m 25s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.TestPread
	hadoop.hdfs.server.namenode.ha.TestHAAppend
	hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy
	hadoop.hdfs.server.datanode.TestBPOfferService
	hadoop.tools.TestHdfsConfigFields

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/5/artifact/out/Dockerfile
GITHUB PR	#2241
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux b9d237abe091 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `82a7505`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/5/artifact/out/diff-checkstyle-root.txt
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/5/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/5/testReport/
Max. process+thread count	4219 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/5/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-08-26T20:00:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	3m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	26m 20s	trunk passed
+1 💚	compile	21m 33s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	18m 54s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	2m 48s	trunk passed
+1 💚	mvnsite	4m 17s	trunk passed
+1 💚	shadedclient	21m 25s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	2m 30s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	3m 59s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	2m 45s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	8m 9s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 27s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 51s	the patch passed
+1 💚	compile	20m 56s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	20m 56s	the patch passed
+1 💚	compile	18m 11s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	18m 11s	the patch passed
-0 ⚠️	checkstyle	2m 44s	root: The patch generated 1 new + 136 unchanged - 2 fixed = 137 total (was 138)
+1 💚	mvnsite	3m 50s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	shadedclient	14m 29s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	2m 21s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	3m 56s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	8m 52s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 35s	hadoop-common in the patch passed.
+1 💚	unit	2m 14s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	113m 4s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 9s	The patch does not generate ASF License warnings.
		316m 36s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestFileChecksumCompositeCrc
	hadoop.hdfs.TestDFSStorageStateRecovery
	hadoop.hdfs.server.balancer.TestBalancer
	hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
	hadoop.hdfs.TestReconstructStripedFile
	hadoop.hdfs.server.namenode.TestFileTruncate
	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication
	hadoop.hdfs.TestFileChecksum
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy
	hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
	hadoop.hdfs.server.namenode.TestReencryptionWithKMS
	hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness
	hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks
	hadoop.hdfs.TestErasureCodeBenchmarkThroughput
	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
	hadoop.hdfs.server.blockmanagement.TestBlockInfoStriped
	hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
	hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/6/artifact/out/Dockerfile
GITHUB PR	#2241
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux 4a4bc1b2b250 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `931adba`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/6/artifact/out/diff-checkstyle-root.txt
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/6/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/6/testReport/
Max. process+thread count	3629 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/6/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

liuml07

Overall looks good to me. A second opinion from @Hexiaoqiao is very appreciated.

hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml

...ect/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java

liuml07

Looks good to me. Will leave to 2nd reviewer to commit after a clean QA run. Thanks!

EDIT: I can commit if no one looks into this again in 3 business days.

1996fanrui · 2020-08-27T06:53:40Z

Looks good to me. Will leave to 2nd reviewer to commit. Thanks!

Thanks for your review. @liuml07

hadoop-yetus · 2020-08-27T08:40:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	3m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	27m 14s	trunk passed
+1 💚	compile	20m 54s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	19m 26s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	3m 31s	trunk passed
+1 💚	mvnsite	4m 22s	trunk passed
+1 💚	shadedclient	25m 12s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	2m 39s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	4m 32s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	3m 7s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	9m 19s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 29s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 12s	the patch passed
+1 💚	compile	23m 4s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	23m 4s	the patch passed
+1 💚	compile	20m 47s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	20m 47s	the patch passed
+1 💚	checkstyle	3m 18s	root: The patch generated 0 new + 136 unchanged - 2 fixed = 136 total (was 138)
+1 💚	mvnsite	4m 10s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	shadedclient	14m 7s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	2m 33s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	3m 58s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	8m 21s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 20s	hadoop-common in the patch passed.
+1 💚	unit	2m 21s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	94m 38s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 7s	The patch does not generate ASF License warnings.
		310m 38s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestFileChecksumCompositeCrc
	hadoop.hdfs.server.namenode.ha.TestHAAppend
	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.hdfs.TestFileChecksum

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/7/artifact/out/Dockerfile
GITHUB PR	#2241
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux 246df61e9427 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `ca8e7a7`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/7/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/7/testReport/
Max. process+thread count	4210 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/7/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-08-27T11:04:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	3m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	26m 15s	trunk passed
+1 💚	compile	19m 24s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	16m 48s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	2m 45s	trunk passed
+1 💚	mvnsite	4m 8s	trunk passed
+1 💚	shadedclient	21m 30s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	2m 35s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	4m 5s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	2m 35s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	7m 55s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 51s	the patch passed
+1 💚	compile	18m 47s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	18m 47s	the patch passed
+1 💚	compile	16m 49s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	16m 49s	the patch passed
+1 💚	checkstyle	2m 46s	root: The patch generated 0 new + 136 unchanged - 2 fixed = 136 total (was 138)
+1 💚	mvnsite	4m 8s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	shadedclient	14m 4s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	2m 34s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	4m 9s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	8m 20s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 48s	hadoop-common in the patch passed.
+1 💚	unit	2m 18s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	96m 54s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 4s	The patch does not generate ASF License warnings.
		292m 58s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.ha.TestHAAppend
	hadoop.hdfs.TestFileChecksum
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
	hadoop.hdfs.TestFileChecksumCompositeCrc
	hadoop.hdfs.server.datanode.TestBPOfferService

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/8/artifact/out/Dockerfile
GITHUB PR	#2241
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux 382b70e7cecd 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `2ffe00f`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/8/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/8/testReport/
Max. process+thread count	4341 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/8/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-08-27T12:09:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 55s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	3m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	26m 34s	trunk passed
+1 💚	compile	20m 8s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	17m 18s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	2m 47s	trunk passed
+1 💚	mvnsite	4m 7s	trunk passed
+1 💚	shadedclient	21m 26s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	2m 35s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	4m 4s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	2m 35s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	7m 59s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 28s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 50s	the patch passed
+1 💚	compile	18m 49s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	18m 49s	the patch passed
+1 💚	compile	17m 34s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	17m 34s	the patch passed
+1 💚	checkstyle	2m 43s	root: The patch generated 0 new + 136 unchanged - 2 fixed = 136 total (was 138)
+1 💚	mvnsite	3m 58s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	shadedclient	16m 32s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	2m 29s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	4m 12s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	9m 51s	the patch passed
		_ Other Tests _
-1 ❌	unit	10m 50s	hadoop-common in the patch passed.
+1 💚	unit	2m 31s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	146m 28s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 15s	The patch does not generate ASF License warnings.
		353m 14s

Reason	Tests
Failed junit tests	hadoop.metrics2.source.TestJvmMetrics
	hadoop.hdfs.TestErasureCodingPolicyWithSnapshot
	hadoop.hdfs.TestFileChecksumCompositeCrc
	hadoop.hdfs.TestFileChecksum
	hadoop.hdfs.TestReconstructStripedFile
	hadoop.hdfs.server.balancer.TestBalancerRPCDelay
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
	hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand
	hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/9/artifact/out/Dockerfile
GITHUB PR	#2241
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux 1629946657fc 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `2ffe00f`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/9/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/9/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/9/testReport/
Max. process+thread count	4104 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/9/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hexiaoqiao

Thanks @1996fanrui @liuml07 for your works, leave some nit comment inline. Please have a look.

hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetUtils.java

...oject/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/DfsClientConf.java

hadoop-yetus · 2020-08-27T20:14:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	3m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	28m 4s	trunk passed
+1 💚	compile	19m 28s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	16m 47s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	2m 48s	trunk passed
+1 💚	mvnsite	4m 6s	trunk passed
+1 💚	shadedclient	20m 34s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	2m 42s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	4m 6s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	3m 13s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	10m 10s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 29s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	25m 7s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	25m 7s	the patch passed
+1 💚	compile	23m 1s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	23m 1s	the patch passed
+1 💚	checkstyle	3m 23s	root: The patch generated 0 new + 136 unchanged - 2 fixed = 136 total (was 138)
+1 💚	mvnsite	4m 32s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	shadedclient	18m 15s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	2m 37s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	4m 27s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	10m 47s	the patch passed
		_ Other Tests _
+1 💚	unit	10m 30s	hadoop-common in the patch passed.
+1 💚	unit	2m 41s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	121m 36s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 7s	The patch does not generate ASF License warnings.
		343m 16s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestErasureCodingPoliciesWithRandomECPolicy
	hadoop.hdfs.TestDFSClientSocketSize
	hadoop.hdfs.TestFileChecksumCompositeCrc
	hadoop.hdfs.TestDecommissionWithBackoffMonitor
	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
	hadoop.hdfs.TestReadStripedFileWithDNFailure
	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
	hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy
	hadoop.hdfs.TestAppendSnapshotTruncate
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.hdfs.TestReadStripedFileWithMissingBlocks
	hadoop.hdfs.TestFileChecksum
	hadoop.hdfs.TestAbandonBlock

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/10/artifact/out/Dockerfile
GITHUB PR	#2241
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux 08b2a55dd876 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `d1c60a5`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/10/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/10/testReport/
Max. process+thread count	4298 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/10/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

1996fanrui · 2020-09-07T08:29:14Z

Hi @liuml07 ,Could you have time to help merge it? Thank you.

liuml07 · 2020-09-07T17:38:05Z

I'm now on vacation. I will merge it this week.

1996fanrui · 2020-09-08T07:25:26Z

I'm now on vacation. I will merge it this week.

ok, thank you very much.

liuml07 · 2020-09-08T21:45:31Z

Was waiting for a clean QA run but could not trigger it manually. If I get no help from community, we can upload the patch file to the JIRA and from there I can trigger multiple runs to get a clean pre-commit build.

I assume failing tests are not related to this patch but it's always nice to confirm.

dineshchitlangia · 2020-09-08T21:58:28Z

@liuml07 You could do an empty commit on the PR branch and push it.
git commit --allow-empty -m 'trigger new CI check' && git push
This should trigger CI

liuml07 · 2020-09-08T22:14:12Z

@1996fanrui could you try the above command shared by @dineshchitlangia to trigger a new PreCommit QA run? Hopefully it will be clean next time. Thanks,

1996fanrui · 2020-09-09T03:11:02Z

Was waiting for a clean QA run but could not trigger it manually. If I get no help from community, we can upload the patch file to the JIRA and from there I can trigger multiple runs to get a clean pre-commit build.

I assume failing tests are not related to this patch but it's always nice to confirm.

Hi @liuml07 , I ran all failed unit tests on my mac. Only one failed: TestHDFSContractMultipartUploader#testConcurrentUploads
It failed are not related to this patch, the community is fixing it, link: https://issues.apache.org/jira/browse/HDFS-15471
Other unit tests are successful on my mac.

1996fanrui · 2020-09-09T03:11:28Z

@1996fanrui could you try the above command shared by @dineshchitlangia to trigger a new PreCommit QA run? Hopefully it will be clean next time. Thanks,

done

hadoop-yetus · 2020-09-09T08:18:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	29m 17s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	3m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	32m 31s	trunk passed
+1 💚	compile	26m 27s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	21m 48s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	3m 28s	trunk passed
+1 💚	mvnsite	4m 31s	trunk passed
+1 💚	shadedclient	26m 14s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	2m 30s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	4m 21s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	3m 23s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	9m 49s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 30s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 22s	the patch passed
+1 💚	compile	19m 13s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	19m 13s	the patch passed
+1 💚	compile	16m 48s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	16m 48s	the patch passed
+1 💚	checkstyle	2m 42s	root: The patch generated 0 new + 136 unchanged - 2 fixed = 136 total (was 138)
+1 💚	mvnsite	4m 3s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	shadedclient	14m 33s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	2m 21s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	3m 53s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	8m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 30s	hadoop-common in the patch passed.
+1 💚	unit	2m 18s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	105m 20s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 21s	The patch does not generate ASF License warnings.
		355m 56s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestGetFileChecksum
	hadoop.hdfs.TestFileChecksumCompositeCrc
	hadoop.hdfs.server.namenode.ha.TestHASafeMode
	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.hdfs.TestMultipleNNPortQOP
	hadoop.hdfs.server.namenode.TestAddStripedBlocks
	hadoop.hdfs.server.namenode.TestNamenodeRetryCache
	hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
	hadoop.hdfs.server.namenode.TestNameEditsConfigs
	hadoop.hdfs.TestFileChecksum
	hadoop.hdfs.server.namenode.TestFsck

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/11/artifact/out/Dockerfile
GITHUB PR	#2241
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux 88a54f877166 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `0d85515`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/11/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/11/testReport/
Max. process+thread count	4040 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2241/11/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

liuml07 · 2020-09-11T03:25:02Z

I see TestNameNodeRetryCacheMetrics.testRetryCacheMetrics and TestMultipleNNPortQOP.testMultipleNNPortOverwriteDownStream fail on my Linux machine with the patch. Will confirm they are not related.

If no objections, I'll commit later today. Thanks,

1996fanrui · 2020-09-11T03:44:20Z

I see TestNameNodeRetryCacheMetrics.testRetryCacheMetrics and TestMultipleNNPortQOP.testMultipleNNPortOverwriteDownStream fail on my Linux machine with the patch. Will confirm they are not related.

If no objections, I'll commit later this week. Thanks,
@liuml07 , thanks for your test.
I run these two unit tests and they are still successful. In the previous test of hadoop robot, TestMultipleNNPortQOP did not fail, only the last time it failed. But the last time I only committed an empty, my code did not change.

liuml07 · 2020-09-11T05:34:05Z

Failing tests are not related and all pass locally in my laptop except TestNameNodeRetryCacheMetrics which is known flaky see HDFS-15458

Contributed by fanrui. Signed-off-by: Mingliang Liu <[email protected]> Signed-off-by: He Xiaoqiao <[email protected]> (cherry picked from commit 56ebabd)

Contributed by fanrui. Signed-off-by: Mingliang Liu <[email protected]> Signed-off-by: He Xiaoqiao <[email protected]> (cherry picked from commit 56ebabd) Change-Id: I9d4ebb5fa13fb2b2a5c78395be8d5b7bd4ccdb81

1996fanrui force-pushed the HADOOP-17222-createSocketAddr-with-cache branch 2 times, most recently from 9878205 to f08b512 Compare August 25, 2020 03:19

Hexiaoqiao reviewed Aug 25, 2020

View reviewed changes

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java Outdated Show resolved Hide resolved

HADOOP-17222. Create socket address combined with cache

5be64e5

1996fanrui force-pushed the HADOOP-17222-createSocketAddr-with-cache branch from f08b512 to 5be64e5 Compare August 25, 2020 06:41

add conf of dfs.client.read.uri.cache.enable

2221aa0

add parameter of uri cache expire time

266831f

refactor to fix checkstyle

f7a46d4

liuml07 reviewed Aug 27, 2020

View reviewed changes

remove parameter of uri cache expire time

e0a0103

1996fanrui force-pushed the HADOOP-17222-createSocketAddr-with-cache branch from a5ccabd to e0a0103 Compare August 27, 2020 06:14

liuml07 approved these changes Aug 27, 2020

View reviewed changes

1996fanrui requested a review from Hexiaoqiao August 27, 2020 07:39

Hexiaoqiao reviewed Aug 27, 2020

View reviewed changes

remove some useless variables

008d865

Hexiaoqiao approved these changes Aug 27, 2020

View reviewed changes

1996fanrui requested a review from liuml07 August 28, 2020 06:07

liuml07 changed the title ~~HADOOP-17222. Create socket address combined with cache~~ HADOOP-17222. Create socket address combined with URI cache Sep 8, 2020

trigger new CI check

9baba78

liuml07 merged commit 56ebabd into apache:trunk Sep 11, 2020

liuml07 removed their request for review September 11, 2020 05:32

HADOOP-17222. Create socket address combined with URI cache #2241

HADOOP-17222. Create socket address combined with URI cache #2241

Uh oh!

Conversation

1996fanrui commented Aug 24, 2020

Uh oh!

hadoop-yetus commented Aug 24, 2020

Uh oh!

Uh oh!

hadoop-yetus commented Aug 25, 2020

Uh oh!

hadoop-yetus commented Aug 25, 2020

Uh oh!

hadoop-yetus commented Aug 25, 2020

Uh oh!

hadoop-yetus commented Aug 26, 2020

Uh oh!

liuml07 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

liuml07 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

1996fanrui commented Aug 27, 2020

Uh oh!

hadoop-yetus commented Aug 27, 2020

Uh oh!

hadoop-yetus commented Aug 27, 2020

Uh oh!

hadoop-yetus commented Aug 27, 2020

Uh oh!

Hexiaoqiao left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hadoop-yetus commented Aug 27, 2020

Uh oh!

1996fanrui commented Sep 7, 2020

Uh oh!

liuml07 commented Sep 7, 2020

Uh oh!

1996fanrui commented Sep 8, 2020

Uh oh!

liuml07 commented Sep 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dineshchitlangia commented Sep 8, 2020

Uh oh!

liuml07 commented Sep 8, 2020

Uh oh!

1996fanrui commented Sep 9, 2020

Uh oh!

1996fanrui commented Sep 9, 2020

Uh oh!

hadoop-yetus commented Sep 9, 2020

Uh oh!

liuml07 commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

1996fanrui commented Sep 11, 2020

Uh oh!

liuml07 commented Sep 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

liuml07 left a comment •

edited

Loading

liuml07 commented Sep 8, 2020 •

edited

Loading

liuml07 commented Sep 11, 2020 •

edited

Loading