You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗
mvndep
3m 19s
Maven dependency ordering for branch
+1 💚
mvninstall
28m 40s
trunk passed
+1 💚
compile
2m 15s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚
compile
1m 55s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚
checkstyle
0m 44s
trunk passed
+1 💚
mvnsite
1m 10s
trunk passed
+1 💚
shadedclient
15m 45s
branch has no errors when building and testing our client artifacts.
+1 💚
javadoc
0m 51s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚
javadoc
0m 48s
trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗
spotbugs
0m 40s
Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚
findbugs
1m 51s
trunk passed
_ Patch Compile Tests _
+0 🆗
mvndep
0m 28s
Maven dependency ordering for patch
+1 💚
mvninstall
0m 53s
the patch passed
+1 💚
compile
2m 9s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚
javac
2m 9s
the patch passed
+1 💚
compile
1m 48s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚
javac
1m 48s
the patch passed
-0 ⚠️
checkstyle
0m 37s
hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 49 new + 102 unchanged - 2 fixed = 151 total (was 104)
+1 💚
mvnsite
0m 53s
the patch passed
+1 💚
whitespace
0m 0s
The patch has no whitespace issues.
+1 💚
shadedclient
13m 33s
patch has no errors when building and testing our client artifacts.
+1 💚
javadoc
0m 42s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚
javadoc
0m 40s
the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
-1 ❌
findbugs
1m 16s
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
_ Other Tests _
-1 ❌
unit
6m 48s
hadoop-mapreduce-client-core in the patch passed.
-1 ❌
unit
2m 31s
hadoop-mapreduce-client-shuffle in the patch passed.
Method org.apache.hadoop.mapreduce.task.reduce.ShuffleHeader.readByVersion(DataInput) seems to be useless At ShuffleHeader.java:useless At ShuffleHeader.java:[line 124]
Method org.apache.hadoop.mapreduce.task.reduce.ShuffleHeader.writeByVersion(DataOutput) seems to be useless At ShuffleHeader.java:useless At ShuffleHeader.java:[line 147]
org.apache.hadoop.mapreduce.task.reduce.ShuffleHeader$HeaderVersion defines compareTo(ShuffleHeader$HeaderVersion) and uses Object.equals() At ShuffleHeader.java:Object.equals() At ShuffleHeader.java:[lines 322-340]
Method org.apache.hadoop.mapreduce.task.reduce.ShuffleHeader.readByVersion(DataInput) seems to be useless At ShuffleHeader.java:useless At ShuffleHeader.java:[line 124]
Method org.apache.hadoop.mapreduce.task.reduce.ShuffleHeader.writeByVersion(DataOutput) seems to be useless At ShuffleHeader.java:useless At ShuffleHeader.java:[line 147]
org.apache.hadoop.mapreduce.task.reduce.ShuffleHeader$HeaderVersion defines compareTo(ShuffleHeader$HeaderVersion) and uses Object.equals() At ShuffleHeader.java:Object.equals() At ShuffleHeader.java:[lines 331-349]
Method org.apache.hadoop.mapreduce.task.reduce.ShuffleHeader.readByVersion(DataInput) seems to be useless At ShuffleHeader.java:useless At ShuffleHeader.java:[line 124]
Method org.apache.hadoop.mapreduce.task.reduce.ShuffleHeader.writeByVersion(DataOutput) seems to be useless At ShuffleHeader.java:useless At ShuffleHeader.java:[line 147]
org.apache.hadoop.mapreduce.task.reduce.ShuffleHeader$HeaderVersion defines compareTo(ShuffleHeader$HeaderVersion) and uses Object.equals() At ShuffleHeader.java:Object.equals() At ShuffleHeader.java:[lines 331-349]
Method org.apache.hadoop.mapreduce.task.reduce.ShuffleHeader.readByVersion(DataInput) seems to be useless At ShuffleHeader.java:useless At ShuffleHeader.java:[line 124]
Method org.apache.hadoop.mapreduce.task.reduce.ShuffleHeader.writeByVersion(DataOutput) seems to be useless At ShuffleHeader.java:useless At ShuffleHeader.java:[line 147]
org.apache.hadoop.mapreduce.task.reduce.ShuffleHeader$HeaderVersion defines compareTo(ShuffleHeader$HeaderVersion) and uses Object.equals() At ShuffleHeader.java:Object.equals() At ShuffleHeader.java:[lines 331-349]
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
Thanks all for your contribution.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MAPREDUCE-7290