Skip to content

Conversation

@mukund-thakur
Copy link
Contributor

Tested by running this test only against ap-south-1 bucket configured with all three encryption algo.

…ryptionOverRename

when server side encryption is not set to sse:kms
@mukund-thakur
Copy link
Contributor Author

CC @steveloughran

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 24m 9s trunk passed
+1 💚 compile 0m 39s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 0m 37s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 checkstyle 0m 24s trunk passed
+1 💚 mvnsite 0m 41s trunk passed
+1 💚 shadedclient 16m 56s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 19s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 0m 27s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗 spotbugs 1m 10s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 1m 8s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 37s the patch passed
+1 💚 compile 0m 36s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 0m 36s the patch passed
+1 💚 compile 0m 28s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 javac 0m 28s the patch passed
+1 💚 checkstyle 0m 19s the patch passed
+1 💚 mvnsite 0m 33s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 15m 25s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 16s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 0m 24s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 findbugs 1m 11s the patch passed
_ Other Tests _
+1 💚 unit 1m 17s hadoop-aws in the patch passed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
70m 11s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2187/1/artifact/out/Dockerfile
GITHUB PR #2187
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux ee46c848b0eb 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / ab2b3df
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2187/1/testReport/
Max. process+thread count 435 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2187/1/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor

Problem is probably that the test depends on the bucket being set up with default encryption = SSE-KMS and a different default key from the test key.

maybe: create a file, look at its encryption, if it's not SSE-KMS then skip the test

@mukund-thakur
Copy link
Contributor Author

Problem is probably that the test depends on the bucket being set up with default encryption = SSE-KMS and a different default key from the test key.

maybe: create a file, look at its encryption, if it's not SSE-KMS then skip the test

Exactly same thing I have done in the patch.

@mukund-thakur
Copy link
Contributor Author

@steveloughran Gentle Reminder to check this one. Thanks.

@steveloughran
Copy link
Contributor

I'm +1-ing the patch, but I'm still not 100% sure it will solve things...it's a complex setup. Let's see

@steveloughran steveloughran merged commit 139a43e into apache:trunk Sep 3, 2020
@steveloughran
Copy link
Contributor

merged, let's leave JIRA open until all is good

@mukund-thakur
Copy link
Contributor Author

Thanks

asfgit pushed a commit that referenced this pull request Sep 4, 2020
Now skips ITestS3AEncryptionWithDefaultS3Settings.testEncryptionOverRename
when server side encryption is not set to sse:kms

Contributed by Mukund Thakur

Change-Id: Ifd83d353e9c7c6f7e1195a2c2f138d85cf876bb1
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
…2187)

Now skips ITestS3AEncryptionWithDefaultS3Settings.testEncryptionOverRename
when server side encryption is not set to sse:kms

Contributed by Mukund Thakur

Change-Id: Ife84aa93adb35298fd255a09189fa0839e4795e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants