Skip to content

HDFS-15371 Nonstandard characters exist in NameNode.java #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhaoyim wants to merge 7 commits into from
Closed

HDFS-15371 Nonstandard characters exist in NameNode.java #2031

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9bd2ac4
HDFS-14308. DFSStripedInputStream curStripeBuf is not freed by unbuff…
zhaoyim Oct 22, 2019
5edfbf8
HDFS-14308. DFSStripedInputStream curStripeBuf is not freed by unbuff…
zhaoyim Oct 22, 2019
c43e5c2
remove the buffer clear in the unbuffer
zhaoyim Oct 23, 2019
23f9c9c
call super unbuffer()
zhaoyim Oct 25, 2019
d15bff0
Merge remote-tracking branch 'mainline/trunk' into trunk
zhaoyim Dec 25, 2019
e7a8c6d
Merge remote-tracking branch 'mainline/trunk' into trunk
zhaoyim May 20, 2020
9bdea07
HDFS-15371 Nonstandard characters exist in NameNode.java
zhaoyim May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...fs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ public enum OperationCategory {
DFS_NAMENODE_KERBEROS_PRINCIPAL_KEY,
DFS_NAMENODE_KERBEROS_INTERNAL_SPNEGO_PRINCIPAL_KEY,
DFS_HA_FENCE_METHODS_KEY,
DFS_HA_ZKFC_PORT_KEY,
Copy link
Member

@goiri goiri May 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the issue with having a comma at the end of an array?

Copy link
Contributor Author

@zhaoyim zhaoyim May 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goiri The issue HDFS-9929 forget to delete the comma.

Copy link
Member

@goiri goiri May 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anything break because of this comma?
I personally don't see a point on removing this.
If we add a new key, it will reduce churn.

Copy link
Contributor Author

@zhaoyim zhaoyim May 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goiri It is not break anything, I think the issue opener means the redundant comma is not formal java grammar.

DFS_HA_ZKFC_PORT_KEY
};

/**
Expand Down