MAPREDUCE-7270. TestHistoryViewerPrinter could be failed when the locale isn't English. by sungpeo · Pull Request #1942 · apache/hadoop

sungpeo · 2020-04-07T06:37:10Z

set locale for the test

hadoop-yetus · 2020-04-07T08:08:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 15s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	22m 42s	trunk passed
+1 💚	compile	0m 42s	trunk passed
+1 💚	checkstyle	0m 37s	trunk passed
+1 💚	mvnsite	0m 49s	trunk passed
+1 💚	shadedclient	19m 26s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 20s	trunk passed
+0 🆗	spotbugs	1m 23s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 21s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 32s	the patch passed
+1 💚	compile	0m 26s	the patch passed
+1 💚	javac	0m 26s	the patch passed
-0 ⚠️	checkstyle	0m 21s	hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 1 new + 105 unchanged - 0 fixed = 106 total (was 105)
+1 💚	mvnsite	0m 30s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 29s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 15s	the patch passed
+1 💚	findbugs	1m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	5m 25s	hadoop-mapreduce-client-core in the patch passed.
+1 💚	asflicense	0m 29s	The patch does not generate ASF License warnings.
		72m 52s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1942/1/artifact/out/Dockerfile
GITHUB PR	#1942
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux c58d79a68b29 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `c12ddbd`
Default Java	1.8.0_242
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1942/1/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1942/1/testReport/
Max. process+thread count	1079 (vs. ulimit of 5500)
modules	C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1942/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-07-31T10:33:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 47s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	19m 57s	trunk passed
+1 💚	compile	0m 40s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	0m 37s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	0m 32s	trunk passed
+1 💚	mvnsite	0m 42s	trunk passed
+1 💚	shadedclient	16m 23s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 16s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	0m 23s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	1m 10s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 6s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 32s	the patch passed
+1 💚	compile	0m 33s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	0m 33s	the patch passed
+1 💚	compile	0m 27s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	javac	0m 27s	the patch passed
-0 ⚠️	checkstyle	0m 21s	hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 1 new + 105 unchanged - 0 fixed = 106 total (was 105)
+1 💚	mvnsite	0m 31s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	13m 51s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 18s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	0m 19s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	findbugs	1m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 1s	hadoop-mapreduce-client-core in the patch passed.
+1 💚	asflicense	0m 29s	The patch does not generate ASF License warnings.
		68m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1942/3/artifact/out/Dockerfile
GITHUB PR	#1942
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 789205e14785 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `e756fe3`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1942/3/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1942/3/testReport/
Max. process+thread count	1608 (vs. ulimit of 5500)
modules	C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1942/3/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

...ient-core/src/test/java/org/apache/hadoop/mapreduce/jobhistory/TestHistoryViewerPrinter.java

liuml07

+1 with a good QA. Thanks!

hadoop-yetus · 2020-09-23T05:14:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	31m 26s		trunk passed
+1 💚	compile	0m 40s		trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	0m 37s		trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	0m 30s		trunk passed
+1 💚	mvnsite	0m 41s		trunk passed
+1 💚	shadedclient	15m 14s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 25s		trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	0m 23s		trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	1m 14s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 13s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 31s		the patch passed
+1 💚	compile	0m 30s		the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	0m 30s		the patch passed
+1 💚	compile	0m 27s		the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	0m 27s		the patch passed
-0 ⚠️	checkstyle	0m 22s	/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt	hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 2 new + 105 unchanged - 0 fixed = 107 total (was 105)
+1 💚	mvnsite	0m 30s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	13m 45s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 20s		the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	0m 20s		the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	1m 13s		the patch passed
			_ Other Tests _
+1 💚	unit	6m 47s		hadoop-mapreduce-client-core in the patch passed.
+1 💚	asflicense	0m 33s		The patch does not generate ASF License warnings.
		79m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1942/6/artifact/out/Dockerfile
GITHUB PR	#1942
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 4c9741279ddc 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `ae089f2`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1942/6/testReport/
Max. process+thread count	1560 (vs. ulimit of 5500)
modules	C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1942/6/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

liuml07 · 2020-09-23T05:42:07Z

...ient-core/src/test/java/org/apache/hadoop/mapreduce/jobhistory/TestHistoryViewerPrinter.java

Sorry I missed in previous review, but do you mind making this a static final variable e.g.

private static final Locale DEFAULT_LOCALE = Locale.getDefault();

?

@liuml07
I think the static DEFAULT_LOCALE which could be stale during other test suites or settings,
because, the DEFAULT_LOCALE will be set before all of the tests.

What do you think about?

This is only initialized during the static @BeforeClass setUp() method, and it will not change during every test cases in this class.

Sorry to confuse you.
I worried that the result of Locale.getDefault() might be changed.

But I get it I don't have to.
I'll push the change.

liuml07 · 2021-03-10T18:58:52Z

I think the Jenkins failed for unrelated issues.

@aajisaka could you tell me how I can trigger a Jenkins run for this again manually?

liuml07 · 2021-03-20T04:04:46Z

Have triggered another run manually: https://ci-hadoop.apache.org/job/hadoop-multibranch/view/change-requests/job/PR-1942/8/

FWIW, the way I trigger it is by logging into the previous build URL (may need committer access) and click the "Replay" button on the left panel.

liuml07 · 2021-03-20T08:23:28Z

Yetus got error

ERROR: Unprocessed flag(s): --findbugs-strict-precheck

Not sure how to proceed. CC: @aajisaka @ayushtkn for help

ayushtkn · 2021-03-20T08:59:17Z

@liuml07 Actually the findbugs support was replaced with spotbugs in HADOOP-16870, I guess that is the reason for the issue.
I have tried to trigger again, by explicitly changing the build script from findbugs to use spotbugs,

https://ci-hadoop.apache.org/job/hadoop-multibranch/view/change-requests/job/PR-1942/10/console

If this too causes any issue, may be we might need to rebase this PR.

liuml07 · 2021-03-23T06:23:05Z

Thank you very much @ayushtkn The report was not posted here, but the new run was fine.

Since there is a checkstyle warning, could you rebase this PR from trunk branch, and also fixe the checkstyle warning @sungpeo ?

./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/jobhistory/TestHistoryViewerPrinter.java:58: Locale.setDefault(DEFAULT_LOCALE);: 'method def' child has incorrect indentation level 6, expected level should be 4. [Indentation]

…ale isn't English. - set Locale.ENGLISH for the test

sungpeo · 2021-04-08T01:39:45Z

@liuml07 Okay, I rebased trunk and fixed the warning.

hadoop-yetus · 2021-04-08T03:09:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 53s		trunk passed
+1 💚	compile	0m 41s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	0m 36s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	0m 38s		trunk passed
+1 💚	mvnsite	0m 43s		trunk passed
+1 💚	javadoc	0m 25s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 23s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	1m 23s		trunk passed
+1 💚	shadedclient	16m 32s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 33s		the patch passed
+1 💚	compile	0m 34s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	0m 34s		the patch passed
+1 💚	compile	0m 30s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	0m 30s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 29s		the patch passed
+1 💚	mvnsite	0m 33s		the patch passed
+1 💚	javadoc	0m 16s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 15s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	1m 24s		the patch passed
+1 💚	shadedclient	16m 4s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	8m 2s	/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt	hadoop-mapreduce-client-core in the patch passed.
+1 💚	asflicense	0m 33s		The patch does not generate ASF License warnings.
		87m 40s

Reason	Tests
Failed junit tests	hadoop.mapred.TestJobEndNotifier

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1942/11/artifact/out/Dockerfile
GITHUB PR	#1942
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 5340e704bc40 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `93cc195`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1942/11/testReport/
Max. process+thread count	1583 (vs. ulimit of 5500)
modules	C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1942/11/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

…ale isn't English. (apache#1942) Contributed by Sungpeo Kook. Signed-off-by: Mingliang Liu <liuml07@apache.org>

liuml07 reviewed Sep 22, 2020

View reviewed changes

...ient-core/src/test/java/org/apache/hadoop/mapreduce/jobhistory/TestHistoryViewerPrinter.java Outdated Show resolved Hide resolved

sungpeo requested a review from liuml07 September 23, 2020 03:55

liuml07 approved these changes Sep 23, 2020

View reviewed changes

liuml07 reviewed Sep 23, 2020

View reviewed changes

elixir-kook and others added 4 commits April 8, 2021 10:37

MAPREDUCE-7270. TestHistoryViewerPrinter could be failed when the loc…

1577295

…ale isn't English. - set Locale.ENGLISH for the test

changed to be static to set locale in test

d0a17b4

Reflect feedback(set DEFAULT_LOCAL static) from lium07

af7c027

correct indentation

93cc195

sungpeo force-pushed the trunk branch from b766668 to 93cc195 Compare April 8, 2021 01:39

liuml07 merged commit 46a5979 into apache:trunk Apr 8, 2021

Conversation

sungpeo commented Apr 7, 2020

Uh oh!

hadoop-yetus commented Apr 7, 2020

Uh oh!

hadoop-yetus commented Jul 31, 2020

Uh oh!

Uh oh!

liuml07 left a comment

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Sep 23, 2020

Uh oh!

liuml07 Sep 23, 2020

Choose a reason for hiding this comment

Uh oh!

sungpeo Mar 8, 2021

Choose a reason for hiding this comment

Uh oh!

liuml07 Mar 9, 2021

Choose a reason for hiding this comment

Uh oh!

sungpeo Mar 9, 2021

Choose a reason for hiding this comment

Uh oh!

liuml07 commented Mar 10, 2021

Uh oh!

liuml07 commented Mar 20, 2021

Uh oh!

liuml07 commented Mar 20, 2021

Uh oh!

ayushtkn commented Mar 20, 2021

Uh oh!

liuml07 commented Mar 23, 2021

Uh oh!

sungpeo commented Apr 8, 2021

Uh oh!

hadoop-yetus commented Apr 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants