Skip to content

HADOOP-16927. Update hadoop-thirdparty dependency version to 1.0.0 #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asfgit merged 1 commit into from
Mar 20, 2020
Merged

HADOOP-16927. Update hadoop-thirdparty dependency version to 1.0.0 #1900

asfgit merged 1 commit into from
Mar 20, 2020

Conversation

@vinayakumarb
Copy link
Contributor

@vinayakumarb vinayakumarb commented Mar 19, 2020

CHANGES

Upgrades the hadoop-thirdparty shaded-protobuf_3.7 artifact to 1.0.0 released version

@vinayakumarb vinayakumarb self-assigned this Mar 19, 2020
ayushtkn
ayushtkn approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Give a check, if Jenkins results, may be it would be timeout, since the changes are at project root...
Thanx @vinayakumarb for the update..

@vinayakumarb
Copy link
Contributor Author

vinayakumarb commented Mar 19, 2020

+1
Give a check, if Jenkins results, may be it would be timeout, since the changes are at project root...
Thanx @vinayakumarb for the update..

Thanks @ayushtkn .
Here is the run https://builds.apache.org/view/H-L/view/Hadoop/job/hadoop-multibranch/view/change-requests/job/PR-1900/1/console
Not sure why comment didnt come here.

@ayushtkn
Copy link
Member

ayushtkn commented Mar 19, 2020

Thanx @vinayakumarb for checking. Seems comment isn't coming, some problem, will check. it isn't coming for patches too.

Anyway the build seems cleans.

@asfgit asfgit merged commit f02d5ab into apache:trunk Mar 20, 2020
@vinayakumarb
Copy link
Contributor Author

vinayakumarb commented Mar 20, 2020

Thanks @ayushtkn for review. Merged to trunk.

@hadoop-yetus
Copy link

hadoop-yetus commented Mar 20, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 4s #1900 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
Subsystem Report/Notes
GITHUB PR #1900
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1900/2/console
versions git=2.17.1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

bilaharith pushed a commit to bilaharith/hadoop that referenced this pull request Mar 23, 2020
@vinayakumarb @bilaharith
HADOOP-16927. Update hadoop-thirdparty dependency version to 1.0.0 (a…
188bd84 
…pache#1900). Contributed by Vinayakumar B.
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
@vinayakumarb @RogPodge
HADOOP-16927. Update hadoop-thirdparty dependency version to 1.0.0 (a…
1105d92 
…pache#1900). Contributed by Vinayakumar B.
zhangxiping1 pushed a commit to zhangxiping1/hadoop that referenced this pull request Dec 13, 2022
@vinayakumarb @zhangxiping1
HADOOP-16927. Update hadoop-thirdparty dependency version to 1.0.0 (a…
944f912 
…pache#1900). Contributed by Vinayakumar B.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ayushtkn ayushtkn ayushtkn approved these changes

@steveloughran steveloughran Awaiting requested review from steveloughran

@aajisaka aajisaka Awaiting requested review from aajisaka

Assignees

@vinayakumarb vinayakumarb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vinayakumarb @ayushtkn @hadoop-yetus @asfgit