HADOOP-16711 Add way to skip verifyBuckets check in S3A fs init() #1845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new exception UnknownStoreException to indicate "there's no store there" * raised in verify bucket existence checks * and when translating AWS exceptions into IOEs * The S3A retry policy fails fast on this * And s3GetFileStatus recognises the same failure and raises it Except when the metastore shortcircuits S3 IO, this means all operations against a nonexistent store will fail with a unique exception. ITestS3ABucketExistence is extended to * disable metastore (getFileStatus(/) was returning a value) * always create new instances * invoke all the operations which catch and swallow FNFEs (exists, isFile, isDir, delete) Change-Id: Ide630ec9738ef971eba603b618bd612456fa064b
Contributor
Author
|
new exception breaks a few tests |
Created a new class org.apache.hadoop.fs.s3a.impl.ErrorTranslation; future work related to mapping from AWS exceptions to IOEs&C can go in there rather than S3AUtils. Moved the checks for an AmazonServiceException being caused by a missing bucket to there; this cleans up uses of the probe. Add a unit test for the recognition/translation. Change-Id: If81573b0c379def4bae715e4395f3ac19857c08e
Contributor
Author
|
Created a new class org.apache.hadoop.fs.s3a.impl.ErrorTranslation; Moved the checks for an AmazonServiceException being caused by Add a unit test for the recognition/translation. test run: all good except for an intermittent problem I've been seeing with the terasorts where the YARN resource localizer is failing as there's a mismatch between file timestamps...people shouldn't be using S3A as the yarn FS, |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
thought: we should make the s3guard tools not dump the whole stack on the failure here, so either
|
Change-Id: I379afa2a10dc7691abb2bd09014fd52a73e3f7f6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1838
Adds a new exception UnknownStoreException to indicate
"there's no store there"
Except when the metastore shortcircuits S3 IO, this means all
operations against a nonexistent store will fail with a unique exception.
ITestS3ABucketExistence is extended to
(exists, isFile, isDir, delete)
also: disable the probe for landsat-pds so that we get more test coverage of the option.
Testing: S3 ireland w/ DDB, and the probe set to 0 by default, everywhere
(No obvious speedup...)