HDDS-2034. Async RATIS pipeline creation and destroy through datanode…

[ChenSammi]

… heartbeat commands.

Old PR link where all previous comments are hosted.
#1469

[ChenSammi]

Rebased on trunk.
@lokeshj1703, @anuengineer , @xiaoyuyao, would you help review the patch at your convenient time?

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	179	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 15 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	94	Maven dependency ordering for branch
-1	mvninstall	67	hadoop-hdds in trunk failed.
-1	mvninstall	55	hadoop-ozone in trunk failed.
-1	compile	23	hadoop-hdds in trunk failed.
-1	compile	19	hadoop-ozone in trunk failed.
+1	checkstyle	82	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	1164	branch has no errors when building and testing our client artifacts.
-1	javadoc	23	hadoop-hdds in trunk failed.
-1	javadoc	25	hadoop-ozone in trunk failed.
0	spotbugs	1284	Used deprecated FindBugs config; considering switching to SpotBugs.
-1	findbugs	44	hadoop-hdds in trunk failed.
-1	findbugs	23	hadoop-ozone in trunk failed.
		_ Patch Compile Tests _
0	mvndep	33	Maven dependency ordering for patch
-1	mvninstall	38	hadoop-hdds in the patch failed.
-1	mvninstall	41	hadoop-ozone in the patch failed.
-1	compile	27	hadoop-hdds in the patch failed.
-1	compile	16	hadoop-ozone in the patch failed.
-1	cc	27	hadoop-hdds in the patch failed.
-1	cc	16	hadoop-ozone in the patch failed.
-1	javac	27	hadoop-hdds in the patch failed.
-1	javac	16	hadoop-ozone in the patch failed.
-0	checkstyle	29	hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	2	The patch has no ill-formed XML file.
+1	shadedclient	805	patch has no errors when building and testing our client artifacts.
-1	javadoc	18	hadoop-hdds in the patch failed.
-1	javadoc	17	hadoop-ozone in the patch failed.
-1	findbugs	28	hadoop-hdds in the patch failed.
-1	findbugs	17	hadoop-ozone in the patch failed.
		_ Other Tests _
-1	unit	24	hadoop-hdds in the patch failed.
-1	unit	23	hadoop-ozone in the patch failed.
+1	asflicense	29	The patch does not generate ASF License warnings.
		3087

Subsystem	Report/Notes
Docker	Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/Dockerfile
GITHUB PR	#1650
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml cc
uname	Linux f338ff149963 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 6e5cd52
Default Java	1.8.0_222
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/branch-compile-hadoop-hdds.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/branch-compile-hadoop-ozone.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/branch-findbugs-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/patch-compile-hadoop-hdds.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/patch-compile-hadoop-ozone.txt
cc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/patch-compile-hadoop-hdds.txt
cc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/patch-compile-hadoop-ozone.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/patch-compile-hadoop-hdds.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/patch-compile-hadoop-ozone.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/patch-findbugs-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/patch-findbugs-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/testReport/
Max. process+thread count	326 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/1/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	41	Docker mode activated.
		_ Prechecks _
+1	dupname	2	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 16 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	67	Maven dependency ordering for branch
-1	mvninstall	37	hadoop-hdds in trunk failed.
-1	mvninstall	40	hadoop-ozone in trunk failed.
-1	compile	20	hadoop-hdds in trunk failed.
-1	compile	16	hadoop-ozone in trunk failed.
+1	checkstyle	60	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	861	branch has no errors when building and testing our client artifacts.
-1	javadoc	23	hadoop-hdds in trunk failed.
-1	javadoc	20	hadoop-ozone in trunk failed.
0	spotbugs	964	Used deprecated FindBugs config; considering switching to SpotBugs.
-1	findbugs	34	hadoop-hdds in trunk failed.
-1	findbugs	21	hadoop-ozone in trunk failed.
		_ Patch Compile Tests _
0	mvndep	29	Maven dependency ordering for patch
-1	mvninstall	34	hadoop-hdds in the patch failed.
-1	mvninstall	36	hadoop-ozone in the patch failed.
-1	compile	24	hadoop-hdds in the patch failed.
-1	compile	19	hadoop-ozone in the patch failed.
-1	cc	24	hadoop-hdds in the patch failed.
-1	cc	19	hadoop-ozone in the patch failed.
-1	javac	24	hadoop-hdds in the patch failed.
-1	javac	19	hadoop-ozone in the patch failed.
+1	checkstyle	57	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	2	The patch has no ill-formed XML file.
+1	shadedclient	717	patch has no errors when building and testing our client artifacts.
-1	javadoc	23	hadoop-hdds in the patch failed.
-1	javadoc	20	hadoop-ozone in the patch failed.
-1	findbugs	31	hadoop-hdds in the patch failed.
-1	findbugs	21	hadoop-ozone in the patch failed.
		_ Other Tests _
-1	unit	28	hadoop-hdds in the patch failed.
-1	unit	27	hadoop-ozone in the patch failed.
+1	asflicense	34	The patch does not generate ASF License warnings.
		2480

Subsystem	Report/Notes
Docker	Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/Dockerfile
GITHUB PR	#1650
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml cc
uname	Linux 9ab173466796 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 336abbd
Default Java	1.8.0_222
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/branch-compile-hadoop-hdds.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/branch-compile-hadoop-ozone.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/branch-findbugs-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/patch-compile-hadoop-hdds.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/patch-compile-hadoop-ozone.txt
cc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/patch-compile-hadoop-hdds.txt
cc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/patch-compile-hadoop-ozone.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/patch-compile-hadoop-hdds.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/patch-compile-hadoop-ozone.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/patch-findbugs-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/patch-findbugs-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/testReport/
Max. process+thread count	412 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1650/2/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.