HDDS-2216. Rename HADOOP_RUNNER_VERSION to OZONE_RUNNER_VERSION in co… #1570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/label ozone |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
/retest |
adoroszlai
approved these changes
Oct 2, 2019
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @cxorm for taking care of this. Acceptance test failures in createmrenv are unrelated.
Member
Author
|
Thanks @adoroszlai |
elek
requested changes
Oct 3, 2019
Member
elek
left a comment
elek
left a comment
There was a problem hiding this comment.
Thank you @cxorm the contribution, overall it looks good to me.
I just found that the blockade tests are doing some magic with this environment variable. As the hadoop-ozone/dist/src/main/compose/ozoneblockade/.env has been changed, they also should be changed.
Would you be so kind to update them in this patch?
hadoop-ozone/fault-injection-test/network-tests/src/test/blockade/ozone/cluster.py
hadoop-ozone/dev-support/checks/blockade.sh
ps: The acceptance test failures all already fixed in HDDS-2187, they will disappear with a rebase
ps2: blockade tests are network failure injection tests similar to the famous Jepsen tests. They are not yet added to the CI (but will be, hopefully soon)
git log $(git merge-base FETCH_HEAD origin/trunk)..origin/trunk --grep=HDDS
Member
Author
|
Thanks @elek |
…mpose .env files.
|
💔 -1 overall
This message was automatically generated. |
Member
Author
|
Thanks @elek and @adoroszlai for the reviews. |
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
…mpose .env files. Closes apache#1570.
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
…mpose .env files. Closes apache#1570.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mpose .env files.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute