HADOOP-16581. Revise ValueQueue to correctly replenish queues that go… #1463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xkrogen
requested changes
Sep 18, 2019
Contributor
xkrogen
left a comment
xkrogen
left a comment
There was a problem hiding this comment.
LGTM, left only very minor comments.
...-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/TestValueQueue.java
Outdated
Show resolved
Hide resolved
...-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/TestValueQueue.java
Outdated
Show resolved
Hide resolved
...-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/TestValueQueue.java
Outdated
Show resolved
Hide resolved
… below the watermark In the existing implementation, the ValueQueue::getAtMost() method will only trigger a refill on a key queue if it has gone empty, instead of triggering a refill when it has gone below the watermark. Revised the test suite to correctly verify this behavior.
yuvaldeg
force-pushed
the
HADOOP-16581
branch
from
ff2016d to
59e393f
Compare
Contributor
|
LGTM, I pinged a few related folks on the JIRA. Also need to get Jenkins to run on this, I'm not sure why it isn't working. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
+1. Changes look good to me. Thanks for pinging me. @xkrogen. |
xkrogen
reviewed
Sep 20, 2019
Contributor
xkrogen
left a comment
xkrogen
left a comment
There was a problem hiding this comment.
+1 from me as well, just merged this.
smengcl
pushed a commit
to smengcl/hadoop
that referenced
this pull request
Oct 8, 2019
…ues that go below the watermark (apache#1463) (cherry picked from dd08346) (cherry picked from e31594f) (cherry picked from commit b091abc) Change-Id: Iceffabadbc9fa6d03119dc266eb275b4cfcea3fc
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
… below the watermark (apache#1463) In the existing implementation, the ValueQueue::getAtMost() method will only trigger a refill on a key queue if it has gone empty, instead of triggering a refill when it has gone below the watermark. Revise the test suite to correctly verify this behavior.
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
… below the watermark (apache#1463) In the existing implementation, the ValueQueue::getAtMost() method will only trigger a refill on a key queue if it has gone empty, instead of triggering a refill when it has gone below the watermark. Revise the test suite to correctly verify this behavior.
bentito
pushed a commit
to bentito/hadoop
that referenced
this pull request
Dec 2, 2020
… below the watermark (apache#1463) (cherry picked from dd08346) (cherry picked from e31594f)
bentito
pushed a commit
to bentito/hadoop
that referenced
this pull request
Dec 3, 2020
… below the watermark (apache#1463) (cherry picked from dd08346) (cherry picked from e31594f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… below the watermark
In the existing implementation, the ValueQueue::getAtMost() method will only trigger a refill on a key queue if it has gone empty, instead of triggering a refill when it has gone below the watermark. Revised the test suite to correctly verify this behavior.