Skip to content

Conversation

@smengcl
Copy link
Contributor

@smengcl smengcl commented Sep 13, 2019

No description provided.

…zone sh command should work with o3:// URI now.
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 40 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
-1 mvninstall 31 hadoop-ozone in trunk failed.
-1 compile 22 hadoop-ozone in trunk failed.
+1 checkstyle 51 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 814 branch has no errors when building and testing our client artifacts.
-1 javadoc 18 hadoop-hdds in trunk failed.
-1 javadoc 18 hadoop-ozone in trunk failed.
0 spotbugs 146 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 26 hadoop-ozone in trunk failed.
_ Patch Compile Tests _
-1 mvninstall 33 hadoop-ozone in the patch failed.
-1 compile 25 hadoop-ozone in the patch failed.
-1 javac 25 hadoop-ozone in the patch failed.
+1 checkstyle 56 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 650 patch has no errors when building and testing our client artifacts.
-1 javadoc 17 hadoop-hdds in the patch failed.
-1 javadoc 18 hadoop-ozone in the patch failed.
-1 findbugs 27 hadoop-ozone in the patch failed.
_ Other Tests _
-1 unit 127 hadoop-hdds in the patch failed.
-1 unit 28 hadoop-ozone in the patch failed.
+1 asflicense 34 The patch does not generate ASF License warnings.
2735
Reason Tests
Failed junit tests hadoop.ozone.container.keyvalue.TestKeyValueContainer
hadoop.ozone.container.ozoneimpl.TestOzoneContainer
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/1/artifact/out/Dockerfile
GITHUB PR #1445
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 60fc3e546740 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 6a9f7ca
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/1/artifact/out/branch-compile-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/1/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/1/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/1/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/1/artifact/out/patch-compile-hadoop-ozone.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/1/artifact/out/patch-compile-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/1/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/1/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/1/artifact/out/patch-findbugs-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/1/testReport/
Max. process+thread count 411 (vs. ulimit of 5500)
modules C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

…mands for buckets and volumes to ensure these commands works under OM HA. [WIP]

Partially inspired by TestS3Shell.
@smengcl
Copy link
Contributor Author

smengcl commented Sep 16, 2019

The patch is complete with an integration test at this point. Please kindly review @bharatviswa504 @arp7 @hanishakoneru . Thanks.

I've also manually tested the ozone sh commands equivalent to the test cases in the new integration test in a docker-compose cluster. They work as intended.

We need to file another jira to fix ozone sh's default OM port behavior, as I mentioned in f799274#diff-f26d13abdbfba6593ea8226585c08986R302.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 45 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 28 Maven dependency ordering for branch
-1 mvninstall 30 hadoop-ozone in trunk failed.
-1 compile 21 hadoop-ozone in trunk failed.
+1 checkstyle 58 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 816 branch has no errors when building and testing our client artifacts.
+1 javadoc 148 trunk passed
0 spotbugs 166 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 26 hadoop-ozone in trunk failed.
_ Patch Compile Tests _
0 mvndep 18 Maven dependency ordering for patch
-1 mvninstall 34 hadoop-ozone in the patch failed.
-1 compile 27 hadoop-ozone in the patch failed.
-1 javac 27 hadoop-ozone in the patch failed.
-0 checkstyle 29 hadoop-ozone: The patch generated 1 new + 29 unchanged - 1 fixed = 30 total (was 30)
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 657 patch has no errors when building and testing our client artifacts.
+1 javadoc 151 the patch passed
-1 findbugs 24 hadoop-ozone in the patch failed.
_ Other Tests _
-1 unit 139 hadoop-hdds in the patch failed.
-1 unit 25 hadoop-ozone in the patch failed.
+1 asflicense 33 The patch does not generate ASF License warnings.
3092
Reason Tests
Failed junit tests hadoop.ozone.container.keyvalue.TestKeyValueContainer
hadoop.ozone.container.ozoneimpl.TestOzoneContainer
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/2/artifact/out/Dockerfile
GITHUB PR #1445
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 363d6de966ac 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 85b1c72
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/2/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/2/artifact/out/branch-compile-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/2/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/2/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/2/artifact/out/patch-compile-hadoop-ozone.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/2/artifact/out/patch-compile-hadoop-ozone.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/2/artifact/out/diff-checkstyle-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/2/artifact/out/patch-findbugs-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/2/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/2/testReport/
Max. process+thread count 426 (vs. ulimit of 5500)
modules C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1445/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@anuengineer anuengineer merged commit d7d6ec8 into apache:trunk Sep 20, 2019
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants