HDDS-1736. Cleanup 2phase old HA code for Key requests. by bharatviswa504 · Pull Request #1038 · apache/hadoop

bharatviswa504 · 2019-06-29T22:14:29Z

No description provided.

hadoop-yetus · 2019-06-29T23:57:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	30	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	13	Maven dependency ordering for branch
+1	mvninstall	481	trunk passed
+1	compile	260	trunk passed
+1	checkstyle	73	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	851	branch has no errors when building and testing our client artifacts.
+1	javadoc	162	trunk passed
0	spotbugs	315	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	502	trunk passed
		_ Patch Compile Tests _
0	mvndep	25	Maven dependency ordering for patch
+1	mvninstall	441	the patch passed
+1	compile	272	the patch passed
+1	cc	272	the patch passed
+1	javac	272	the patch passed
-0	checkstyle	43	hadoop-ozone: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	682	patch has no errors when building and testing our client artifacts.
+1	javadoc	158	the patch passed
+1	findbugs	518	the patch passed
		_ Other Tests _
+1	unit	248	hadoop-hdds in the patch passed.
-1	unit	1082	hadoop-ozone in the patch failed.
+1	asflicense	51	The patch does not generate ASF License warnings.
		6113

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1038/1/artifact/out/Dockerfile
GITHUB PR	#1038
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 7463d7fcdeb1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `d203045`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1038/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1038/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1038/1/testReport/
Max. process+thread count	4896 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1038/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

arp7

+1 LGTM

arp7 · 2019-07-16T00:49:48Z

+1 LGTM. Feel free to commit with checkstyle issues fixed.

I assume you verified the test failures are unrelated.

bharatviswa504 · 2019-07-16T01:17:11Z

/retest

bharatviswa504 · 2019-07-16T01:17:20Z

/retest

hadoop-yetus · 2019-07-16T03:10:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	40	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	49	Maven dependency ordering for branch
+1	mvninstall	499	trunk passed
+1	compile	267	trunk passed
+1	checkstyle	79	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	883	branch has no errors when building and testing our client artifacts.
+1	javadoc	167	trunk passed
0	spotbugs	312	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	507	trunk passed
		_ Patch Compile Tests _
0	mvndep	26	Maven dependency ordering for patch
+1	mvninstall	444	the patch passed
+1	compile	273	the patch passed
+1	cc	273	the patch passed
+1	javac	273	the patch passed
+1	checkstyle	85	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	677	patch has no errors when building and testing our client artifacts.
+1	javadoc	166	the patch passed
+1	findbugs	531	the patch passed
		_ Other Tests _
-1	unit	290	hadoop-hdds in the patch failed.
-1	unit	1641	hadoop-ozone in the patch failed.
+1	asflicense	55	The patch does not generate ASF License warnings.
		6859

Reason	Tests
Failed junit tests	hadoop.hdds.scm.container.TestReplicationManager
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1038/2/artifact/out/Dockerfile
GITHUB PR	#1038
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 9c00d285b1db 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `ef66e49`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1038/2/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1038/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1038/2/testReport/
Max. process+thread count	5341 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1038/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

bharatviswa504 · 2019-07-16T04:51:43Z

Thank You @arp7 for the review.
I will commit this to the trunk. Ran S3 secure acceptance test suite locally, tests are passing. Test failures are not related to this patch.

hadoop-yetus · 2019-07-16T06:44:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	93	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	32	Maven dependency ordering for branch
+1	mvninstall	507	trunk passed
+1	compile	270	trunk passed
+1	checkstyle	78	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	857	branch has no errors when building and testing our client artifacts.
+1	javadoc	166	trunk passed
0	spotbugs	314	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	506	trunk passed
		_ Patch Compile Tests _
0	mvndep	27	Maven dependency ordering for patch
+1	mvninstall	458	the patch passed
+1	compile	275	the patch passed
+1	cc	275	the patch passed
+1	javac	275	the patch passed
+1	checkstyle	83	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	700	patch has no errors when building and testing our client artifacts.
+1	javadoc	164	the patch passed
+1	findbugs	525	the patch passed
		_ Other Tests _
+1	unit	345	hadoop-hdds in the patch passed.
-1	unit	2782	hadoop-ozone in the patch failed.
+1	asflicense	57	The patch does not generate ASF License warnings.
		8110

Reason	Tests
Failed junit tests	hadoop.ozone.scm.TestXceiverClientManager
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.scm.pipeline.TestSCMPipelineMetrics
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1038/3/artifact/out/Dockerfile
GITHUB PR	#1038
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc
uname	Linux 4a3565272a07 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `f77d54c`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1038/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1038/3/testReport/
Max. process+thread count	5352 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common hadoop-ozone/ozone-manager U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1038/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

…1038) * SAMZA-2196: [Scala cleanup] Convert SerializerConfig to Java * rename JavaSerializerConfig to SerializerConfig * clarify method names, use Class.getName

bharatviswa504 requested review from arp7 and hanishakoneru June 29, 2019 22:14

bharatviswa504 self-assigned this Jun 29, 2019

bharatviswa504 added the ozone label Jun 29, 2019

arp7 approved these changes Jul 16, 2019

View reviewed changes

bharatviswa504 added 2 commits July 15, 2019 18:15

HDDS-1736. Cleanup 2phase old HA code for allocateBlock request.

3f4193e

fix checkstyle.

df0ba53

bharatviswa504 force-pushed the HDDS-1736 branch from 172c44d to df0ba53 Compare July 16, 2019 01:15

bharatviswa504 closed this Jul 16, 2019

bharatviswa504 reopened this Jul 16, 2019

remove isRatisEnabled check.

d741b12

bharatviswa504 merged commit 395cb3c into apache:trunk Jul 16, 2019

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019

HDDS-1736. Cleanup 2phase old HA code for Key requests. (apache#1038)

0ade4f5

MarcelRaschke mentioned this pull request Aug 19, 2022

[Snyk] Fix for 3 vulnerabilities MarcelRaschke/hadoop#13

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDDS-1736. Cleanup 2phase old HA code for Key requests.#1038

HDDS-1736. Cleanup 2phase old HA code for Key requests.#1038
bharatviswa504 merged 3 commits intoapache:trunkfrom
bharatviswa504:HDDS-1736

bharatviswa504 commented Jun 29, 2019

Uh oh!

hadoop-yetus commented Jun 29, 2019

Uh oh!

arp7 left a comment

Uh oh!

arp7 commented Jul 16, 2019

Uh oh!

bharatviswa504 commented Jul 16, 2019

Uh oh!

bharatviswa504 commented Jul 16, 2019

Uh oh!

hadoop-yetus commented Jul 16, 2019

Uh oh!

bharatviswa504 commented Jul 16, 2019 •

edited

Loading

Uh oh!

hadoop-yetus commented Jul 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bharatviswa504 commented Jun 29, 2019

Uh oh!

hadoop-yetus commented Jun 29, 2019

Uh oh!

arp7 left a comment

Choose a reason for hiding this comment

Uh oh!

arp7 commented Jul 16, 2019

Uh oh!

bharatviswa504 commented Jul 16, 2019

Uh oh!

bharatviswa504 commented Jul 16, 2019

Uh oh!

hadoop-yetus commented Jul 16, 2019

Uh oh!

bharatviswa504 commented Jul 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hadoop-yetus commented Jul 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bharatviswa504 commented Jul 16, 2019 •

edited

Loading