HDDS-1730. Implement File CreateDirectory Request to use Cache and Do…#1026
Merged
bharatviswa504 merged 6 commits intoapache:trunkfrom Jul 1, 2019
Merged
HDDS-1730. Implement File CreateDirectory Request to use Cache and Do…#1026bharatviswa504 merged 6 commits intoapache:trunkfrom
bharatviswa504 merged 6 commits intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
bharatviswa504
force-pushed
the
HDDS-1730
branch
from
cd4a789 to
0877e85
Compare
|
💔 -1 overall
This message was automatically generated. |
bharatviswa504
force-pushed
the
HDDS-1730
branch
from
f1ab2ee to
2d646d0
Compare
bharatviswa504
force-pushed
the
HDDS-1730
branch
from
2d646d0 to
0764482
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
arp7
reviewed
Jun 30, 2019
| import org.apache.hadoop.ozone.om.OzoneManager; | ||
| import org.apache.hadoop.ozone.om.ratis.utils.OzoneManagerRatisUtils; | ||
| import org.apache.hadoop.ozone.om.response.OMClientResponse; | ||
| import org.apache.hadoop.ozone.om.response.file.OMDirectoryCreateResponse; |
arp7
reviewed
Jun 30, 2019
|
|
||
| // Check if this is the root of the filesystem. | ||
| if (keyName.length() == 0) { | ||
| return new OMDirectoryCreateResponse(null, |
Contributor
There was a problem hiding this comment.
A future improvement unrelated to your patch - replace null with Optional. Or at least add @nullable annotation on the parameter.
Contributor
Author
There was a problem hiding this comment.
Added @nullable. Will open a new jira to do the same for Other OMResponse classes.
Contributor
Author
There was a problem hiding this comment.
arp7
reviewed
Jun 30, 2019
| acquiredLock = omMetadataManager.getLock().acquireLock(BUCKET_LOCK, | ||
| volumeName, bucketName); | ||
|
|
||
| // TODO: Not checking volume exist here, once we have full cache we can |
Contributor
There was a problem hiding this comment.
Let's file a blocker Jira for this so it doesn't slip somehow.
Contributor
Author
There was a problem hiding this comment.
This check is to throw a specific error like volume not found.
I think this is right now not a blocker, it is similar to what we have done in Key requests.
https://issues.apache.org/jira/browse/HDDS-1737
arp7
approved these changes
Jun 30, 2019
Contributor
arp7
left a comment
arp7
left a comment
There was a problem hiding this comment.
+1 LGTM. A few minor comments unrelated to the patch, and looks like there is one checkstyle issue of unused imports.
Please verify UT and acceptance failures are unrelated, most likely the case.
Contributor
Author
|
Thank You @arp7 for the review. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
Test failures are not related to this patch. |
bshashikant
pushed a commit
to bshashikant/hadoop
that referenced
this pull request
Jul 10, 2019
shanthoosh
added a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…ner startup sequence. (apache#1026) * Resolve startpoint to offset before registering with SystemConsumer. * Add unit tests. * Address review comments.
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ubleBuffer.