HDDS-1728. Add metrics for leader's latency in ContainerStateMachine. Contributed by Mukul Kumar Singh.#1022
Merged
mukul1987 merged 2 commits intoapache:trunkfrom Jul 8, 2019
Merged
Conversation
… Contributed by Mukul Kumar Singh.
|
💔 -1 overall
This message was automatically generated. |
lokeshj1703
requested changes
Jul 2, 2019
Contributor
lokeshj1703
left a comment
lokeshj1703
left a comment
There was a problem hiding this comment.
@mukul1987 Thanks for working on this! The changes look good to me. I have a few minor comments.
| dispatcher.validateContainerCommand(proto); | ||
| } catch (IOException ioe) { | ||
| if (ioe instanceof ContainerNotOpenException) { | ||
| metrics.intNumContainerNotOpenVerifyFailures(); |
Contributor
There was a problem hiding this comment.
intNumContainerNotOpenVerifyFailures should be in'c'NumContainerNotOpenVerifyFailures.
| private @Metric MutableCounterLong numContainerNotOpenVerifyFailures; | ||
|
|
||
| public CSMMetrics() { | ||
| int numEnumEntries = ContainerProtos.Type.values().length; |
Contributor
There was a problem hiding this comment.
Can we rename numEnumEntries to numCmdTypes or sth like that?
| public CSMMetrics() { | ||
| int numEnumEntries = ContainerProtos.Type.values().length; | ||
| this.opsLatency = new MutableRate[numEnumEntries]; | ||
| this.registry = new MetricsRegistry("CSMMetrics"); |
Contributor
There was a problem hiding this comment.
We can use CSMMetrics.class.getName() here.
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
@mukul1987 Thanks for updating the PR. The changes look good to me. +1. |
bshashikant
pushed a commit
to bshashikant/hadoop
that referenced
this pull request
Jul 10, 2019
… Contributed by Mukul Kumar Singh. (apache#1022)
shanthoosh
added a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
… Contributed by Mukul Kumar Singh. (apache#1022)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This jira adds metrics around leaders latency for pipeline operations.