HADOOP-19062. [thirdparty] Improve create-release RUN script. #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slfan1989
changed the title
Hexiaoqiao
reviewed
Feb 2, 2024
| echo "RUN groupadd --non-unique -g ${group_id} ${user_name}" | ||
| echo "RUN useradd -g ${group_id} -u ${user_id} -m ${user_name}" | ||
| echo "RUN chown -R ${user_name} /home/${user_name}" | ||
| echo "RUN groupadd --non-unique -g ${group_id} ${user_name}; exit 0;" |
Contributor
Author
There was a problem hiding this comment.
@Hexiaoqiao Thank you for reviewing the code!
We have improved the hadoop script at apache/hadoop#6448. I think hadoop-thirdparty should also be improved.
Hexiaoqiao
approved these changes
Feb 2, 2024
Hexiaoqiao
left a comment
Hexiaoqiao
left a comment
There was a problem hiding this comment.
LGTM. +1. Another one same PR (HADOOP-19038) is for hadoop repo.
Contributor
Author
|
@Hexiaoqiao Thanks for reviewing the code! merged into trunk. |
slfan1989
added a commit
that referenced
this pull request
Feb 4, 2024
… Shilun Fan Reviewed-by: He Xiaoqiao <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
slfan1989
added a commit
that referenced
this pull request
Feb 4, 2024
… Shilun Fan Reviewed-by: He Xiaoqiao <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
JIRA: HADOOP-19062. Improve create-release RUN script.
This change is similar to HADOOP-19038 of hadoop-trunk.