[#8940] improvement(core): Support serialize/deserialize for distributionImpl and sortOrderImpl#8975
Merged
jerryshao merged 7 commits intoapache:branch-lance-namepspace-devfrom Nov 4, 2025
Conversation
jerryshao
reviewed
Oct 31, 2025
| gen.writeEndObject(); | ||
| } | ||
|
|
||
| private static void writeExpression(Expression expression, JsonGenerator gen) throws IOException { |
Contributor
There was a problem hiding this comment.
I guess the implementation is quite similar to xxxDTO serde, maybe we can reuse the code. Otherwise, we have to change twice.
Another solution is that when we store these into the database, we can convert the xxxImpl to xxxDTO, and then using the existing serde method to do the serialization and deserialization. With this, we don't have to implement the serde method for these xxxImpl.
Contributor
Author
There was a problem hiding this comment.
In the first edition, I have just converted Impl to DTO and reused the DTO serializer and deserializer to handle it. However, since DTO and Impl play different roles, I chose to create new serializers finally. Theoretically, both are okay.
Contributor
There was a problem hiding this comment.
Let's do the second one if there's no objection, cc @mchades .
jerryshao
reviewed
Nov 3, 2025
jerryshao
reviewed
Nov 3, 2025
jerryshao
reviewed
Nov 3, 2025
jerryshao
approved these changes
Nov 4, 2025
jerryshao
merged commit 8782b30
into
apache:branch-lance-namepspace-dev
26 checks passed
jerryshao
pushed a commit
to jerryshao/gravitino
that referenced
this pull request
Nov 11, 2025
…stributionImpl and sortOrderImpl (apache#8975) ### What changes were proposed in this pull request? - Add serializer and deserializer for class `DistributionImpl` and `SortOrderImpl` - Optimize sortOrderImpl serialization. ### Why are the changes needed? It's a improvment. Fix: apache#8940 ### Does this PR introduce _any_ user-facing change? N/A. ### How was this patch tested? UTs and ITs.
youngyjd
pushed a commit
to youngyjd/gravitino
that referenced
this pull request
Nov 21, 2025
…stributionImpl and sortOrderImpl (apache#8975) ### What changes were proposed in this pull request? - Add serializer and deserializer for class `DistributionImpl` and `SortOrderImpl` - Optimize sortOrderImpl serialization. ### Why are the changes needed? It's a improvment. Fix: apache#8940 ### Does this PR introduce _any_ user-facing change? N/A. ### How was this patch tested? UTs and ITs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
DistributionImplandSortOrderImplWhy are the changes needed?
It's a improvment.
Fix: #8940
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
UTs and ITs.