[#8955] feat(lance-rest): Support register and deregister table in Lance REST server.#8964
Conversation
…raviton into issue_8955
…raviton into issue_8955
|
@mchades can you please help to review and get this merged quickly? |
|
plz resolve the conflicts |
…raviton into issue_8955
done |
| @HeaderParam("x-lance-table-location") String tableLocation, | ||
| @HeaderParam("x-lance-table-properties") String tableProperties, | ||
| @HeaderParam("x-lance-root-catalog") String rootCatalog, |
There was a problem hiding this comment.
Are these the Lance rest spec defined headers?
There was a problem hiding this comment.
Lance defines that the format of headers should be with prefixes x-lance and there is no description on the detail things such as property names. However, lance spark did use some constant header like x-lance-database, x-lance-table-location.
There was a problem hiding this comment.
Lance defines that the format of headers should be with prefixes
x-lance
Can you provide a source link for this?
There was a problem hiding this comment.
We'd better not leverage something that is in the header and only used in one or two clients; we should not make such an assumption. Can we confirm with the Lance guy?
There was a problem hiding this comment.
They only define the parameters x-lance-table-properties and x-lance-table-location, but do not define the headers that should have the prefix x-lance.
There was a problem hiding this comment.
In fact, all known header attribute names start with "x-lance" except auth-related configurations, which misleads me.
|
|
||
| dependencies { | ||
| implementation(project(":clients:client-java-runtime", configuration = "shadow")) | ||
| implementation(project(":clients:client-java")) |
yuqi1129
merged commit 48342ac
into
apache:branch-lance-namepspace-dev
… in Lance REST server. (apache#8964) ### What changes were proposed in this pull request? Support API `registerTable` and `deregisterTable` in Lance REST server. ### Why are the changes needed? It's from user requirement. Fix: apache#8955 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? Test locally.
… in Lance REST server. (apache#8964) ### What changes were proposed in this pull request? Support API `registerTable` and `deregisterTable` in Lance REST server. ### Why are the changes needed? It's from user requirement. Fix: apache#8955 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? Test locally.
3 participants
What changes were proposed in this pull request?
Support API
registerTableandderegisterTablein Lance REST server.Why are the changes needed?
It's from user requirement.
Fix: #8955
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Test locally.