[#8921] improvement(catalogs): Add ITs for lance table operations.#8923
Merged
yuqi1129 merged 5 commits intoapache:branch-lance-namepspace-devfrom Oct 28, 2025
Merged
[#8921] improvement(catalogs): Add ITs for lance table operations.#8923yuqi1129 merged 5 commits intoapache:branch-lance-namepspace-devfrom
yuqi1129 merged 5 commits intoapache:branch-lance-namepspace-devfrom
Conversation
mchades
reviewed
Oct 28, 2025
mchades
reviewed
Oct 28, 2025
mchades
previously approved these changes
Oct 28, 2025
mchades
reviewed
Oct 28, 2025
| implementation(libs.commons.lang3) | ||
| implementation(libs.guava) | ||
| implementation(libs.hadoop3.client.api) | ||
| implementation(libs.hadoop3.client.runtime) |
Contributor
Author
There was a problem hiding this comment.
In the method dropTable, the following code will lack necessary dependencies if there exists only hadoop-client-api
FileSystem fs = FileSystem.get(new Configuration());
return fs.delete(new Path(location), true);They should show up together.
Contributor
Author
There was a problem hiding this comment.
I will optimize this part in another PR and remove the use of FileSystem here.
jerryshao
reviewed
Oct 28, 2025
| public class TableVersionPostgreSQLProvider extends TableVersionBaseSQLProvider { | ||
|
|
||
| public class TableVersionPostgreSQLProvider extends TableVersionBaseSQLProvider {} | ||
| public String insertTableVersionOnDuplicateKeyUpdate(@Param("tablePO") TablePO tablePO) { |
Contributor
There was a problem hiding this comment.
Can you add UTs for this part?
jerryshao
reviewed
Oct 28, 2025
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class CatalogGenericLakeLanceIT extends BaseIT { |
yuqi1129
commented
Oct 28, 2025
|
|
||
| // Note: GenericTableEntity will be removed in the refactor PR, so here just keep the old | ||
| // logic to make the UT pass. | ||
| if (newTable instanceof GenericTableEntity genericTable) { |
Contributor
Author
There was a problem hiding this comment.
This is a temporary change to make the CI pass, and #8922 will remove the class GenericTableEntity and use TableEntity.
Contributor
Author
|
@jerryshao @mchades |
yuqi1129
merged commit d0c58f9
into
apache:branch-lance-namepspace-dev
26 checks passed
jerryshao
pushed a commit
to jerryshao/gravitino
that referenced
this pull request
Nov 11, 2025
…ns. (apache#8923) ### What changes were proposed in this pull request? Add some ITs to covert lance table operations and fix a bug by the way. ### Why are the changes needed? It's a improvement. Fix: apache#8921 ### Does this PR introduce _any_ user-facing change? N/A. ### How was this patch tested? It's self just the test.
youngyjd
pushed a commit
to youngyjd/gravitino
that referenced
this pull request
Nov 20, 2025
…ns. (apache#8923) ### What changes were proposed in this pull request? Add some ITs to covert lance table operations and fix a bug by the way. ### Why are the changes needed? It's a improvement. Fix: apache#8921 ### Does this PR introduce _any_ user-facing change? N/A. ### How was this patch tested? It's self just the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add some ITs to covert lance table operations and fix a bug by the way.
Why are the changes needed?
It's a improvement.
Fix: #8921
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
It's self just the test.