Skip to content

[#8909] feat(lance): Add metric systems to lance server#8904

Merged
jerryshao merged 9 commits intoapache:branch-lance-namepspace-devfrom
youngyjd:add-metric-systems-lance-server
Oct 24, 2025
Merged

[#8909] feat(lance): Add metric systems to lance server#8904
jerryshao merged 9 commits intoapache:branch-lance-namepspace-devfrom
youngyjd:add-metric-systems-lance-server

Conversation

@youngyjd
Copy link
Copy Markdown
Contributor

@youngyjd youngyjd commented Oct 23, 2025

What changes were proposed in this pull request?

  1. Added Lance REST server metrics constant (MetricsSource.java)
  2. Added MapperConfig rule to transform Dropwizard metrics to Prometheus format
  3. Integrated metrics collection in Lance REST service (LanceRESTService.java)
  4. Enables automatic exposure of metrics at /metrics and /prometheus/metrics endpoints

Why are the changes needed?

Observability is needed for the new lance rest service.

Fix: #8909

Does this PR introduce any user-facing change?

Yes - New metrics endpoints

Standalone mode:

Auxiliary mode:

  • Metrics exposed on all service ports (8090, 9001, 9101) showing unified metrics from all services

How was this patch tested?

Unit tests

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also add the metric annotation to the rest method

@youngyjd youngyjd force-pushed the add-metric-systems-lance-server branch from 2a4d92d to b755d28 Compare October 24, 2025 03:12
@youngyjd youngyjd closed this Oct 24, 2025
@youngyjd youngyjd reopened this Oct 24, 2025
@jerryshao jerryshao changed the title feat(lance): Add metric systems to lance server [#8909] feat(lance): Add metric systems to lance server Oct 24, 2025
@jerryshao jerryshao merged commit 67179e6 into apache:branch-lance-namepspace-dev Oct 24, 2025
26 checks passed
jerryshao added a commit to jerryshao/gravitino that referenced this pull request Nov 11, 2025
…#8904)

### What changes were proposed in this pull request?

1. Added Lance REST server metrics constant (MetricsSource.java)
2. Added MapperConfig rule to transform Dropwizard metrics to Prometheus
format
3. Integrated metrics collection in Lance REST service
(LanceRESTService.java)
4. Enables automatic exposure of metrics at /metrics and
/prometheus/metrics endpoints

### Why are the changes needed?

Observability is needed for the new lance rest service.

Fix: apache#8909 

### Does this PR introduce _any_ user-facing change?

Yes - New metrics endpoints

Standalone mode:
- http://localhost:9101/metrics (Dropwizard JSON format)
- http://localhost:9101/prometheus/metrics (Prometheus text format)

Auxiliary mode:
- Metrics exposed on all service ports (8090, 9001, 9101) showing
unified metrics from all services

### How was this patch tested?

Unit tests

---------

Co-authored-by: Jerry Shao <jerryshao@datastrato.com>
youngyjd added a commit to youngyjd/gravitino that referenced this pull request Nov 18, 2025
…#8904)

### What changes were proposed in this pull request?

1. Added Lance REST server metrics constant (MetricsSource.java)
2. Added MapperConfig rule to transform Dropwizard metrics to Prometheus
format
3. Integrated metrics collection in Lance REST service
(LanceRESTService.java)
4. Enables automatic exposure of metrics at /metrics and
/prometheus/metrics endpoints

### Why are the changes needed?

Observability is needed for the new lance rest service.

Fix: apache#8909 

### Does this PR introduce _any_ user-facing change?

Yes - New metrics endpoints

Standalone mode:
- http://localhost:9101/metrics (Dropwizard JSON format)
- http://localhost:9101/prometheus/metrics (Prometheus text format)

Auxiliary mode:
- Metrics exposed on all service ports (8090, 9001, 9101) showing
unified metrics from all services

### How was this patch tested?

Unit tests

---------

Co-authored-by: Jerry Shao <jerryshao@datastrato.com>
youngyjd added a commit to youngyjd/gravitino that referenced this pull request Nov 19, 2025
…#8904)

### What changes were proposed in this pull request?

1. Added Lance REST server metrics constant (MetricsSource.java)
2. Added MapperConfig rule to transform Dropwizard metrics to Prometheus
format
3. Integrated metrics collection in Lance REST service
(LanceRESTService.java)
4. Enables automatic exposure of metrics at /metrics and
/prometheus/metrics endpoints

### Why are the changes needed?

Observability is needed for the new lance rest service.

Fix: apache#8909 

### Does this PR introduce _any_ user-facing change?

Yes - New metrics endpoints

Standalone mode:
- http://localhost:9101/metrics (Dropwizard JSON format)
- http://localhost:9101/prometheus/metrics (Prometheus text format)

Auxiliary mode:
- Metrics exposed on all service ports (8090, 9001, 9101) showing
unified metrics from all services

### How was this patch tested?

Unit tests

---------

Co-authored-by: Jerry Shao <jerryshao@datastrato.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants