[#8871]Improve(core): fix EntityCacheWeigher and testPolicyAndTagCacheWeigher#8871
Merged
yuqi1129 merged 4 commits intoapache:mainfrom Oct 22, 2025
Merged
[#8871]Improve(core): fix EntityCacheWeigher and testPolicyAndTagCacheWeigher#8871yuqi1129 merged 4 commits intoapache:mainfrom
yuqi1129 merged 4 commits intoapache:mainfrom
Conversation
youngyjd
changed the title
Contributor
|
It seems that we need to clear the evicted cache synchronously, just as what you have done here or a long timeout could not guarantee the test can pass. |
yuqi1129
reviewed
Oct 22, 2025
youngyjd
changed the title
youngyjd
changed the title
yuqi1129
approved these changes
Oct 22, 2025
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 22, 2025
…heWeigher (#8871) ### What changes were proposed in this pull request? Fix EntityCacheWeigher priorities and update cache eviction test This commit corrects the entity weight configuration in EntityCacheWeigher and updates the corresponding test to validate the new behavior. The previous weight configuration was inverted: - Schema: weight=500 (incorrectly high, causing unwanted evictions) - Tag/Policy: weight=100 (incorrectly low, preventing desired evictions) This violated the Caffeine cache principle where higher weights lead to higher eviction priority. ### Why are the changes needed? Correct EntityCacheWeigher and fix the flaky test of testPolicyAndTagCacheWeigher Fix: #8861 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test updated
yuqi1129
pushed a commit
that referenced
this pull request
Oct 23, 2025
…heWeigher (#8875) ### What changes were proposed in this pull request? Fix EntityCacheWeigher priorities and update cache eviction test This commit corrects the entity weight configuration in EntityCacheWeigher and updates the corresponding test to validate the new behavior. The previous weight configuration was inverted: - Schema: weight=500 (incorrectly high, causing unwanted evictions) - Tag/Policy: weight=100 (incorrectly low, preventing desired evictions) This violated the Caffeine cache principle where higher weights lead to higher eviction priority. ### Why are the changes needed? Correct EntityCacheWeigher and fix the flaky test of testPolicyAndTagCacheWeigher Fix: #8861 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test updated Co-authored-by: Junda Yang <junda@uber.com>
yuqi1129
pushed a commit
to yuqi1129/gravitino
that referenced
this pull request
Oct 24, 2025
…TagCacheWeigher (apache#8871) ### What changes were proposed in this pull request? Fix EntityCacheWeigher priorities and update cache eviction test This commit corrects the entity weight configuration in EntityCacheWeigher and updates the corresponding test to validate the new behavior. The previous weight configuration was inverted: - Schema: weight=500 (incorrectly high, causing unwanted evictions) - Tag/Policy: weight=100 (incorrectly low, preventing desired evictions) This violated the Caffeine cache principle where higher weights lead to higher eviction priority. ### Why are the changes needed? Correct EntityCacheWeigher and fix the flaky test of testPolicyAndTagCacheWeigher Fix: apache#8861 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test updated
jerryshao
pushed a commit
that referenced
this pull request
Oct 24, 2025
…heWeigher (#8871) ### What changes were proposed in this pull request? Fix EntityCacheWeigher priorities and update cache eviction test This commit corrects the entity weight configuration in EntityCacheWeigher and updates the corresponding test to validate the new behavior. The previous weight configuration was inverted: - Schema: weight=500 (incorrectly high, causing unwanted evictions) - Tag/Policy: weight=100 (incorrectly low, preventing desired evictions) This violated the Caffeine cache principle where higher weights lead to higher eviction priority. ### Why are the changes needed? Correct EntityCacheWeigher and fix the flaky test of testPolicyAndTagCacheWeigher Fix: #8861 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix EntityCacheWeigher priorities and update cache eviction test
This commit corrects the entity weight configuration in EntityCacheWeigher and updates the corresponding test to validate the new behavior.
The previous weight configuration was inverted:
This violated the Caffeine cache principle where higher weights lead to higher eviction priority.
Why are the changes needed?
Correct EntityCacheWeigher and fix the flaky test of testPolicyAndTagCacheWeigher
Fix: #8861
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test updated