[#6475] improvement: Disable the ryuk

[jerqi]

What changes were proposed in this pull request?

Disable the ryuk

Why are the changes needed?

Fix: #6475

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI passed.

[yuqi1129]

I don't think disabling ryuk globally is a good choice, when the rynk is disabled, developers need to clean up docker resources when testing locally. Could you please limit the scope and disable rynk in the module that needs to clean resource manually?

[jerqi]

@youngyjd Maybe you can apply this commit. This may solve your issue.

[jerqi]

I don't think disabling ryuk globally is a good choice, when the rynk is disabled, developers need to clean up docker resources when testing locally. Could you please limit the scope and disable rynk in the module that needs to clean resource manually?

It seems ok that the container can be cleaned normally although we disable ryuk. I tried locally.

[yuqi1129]

I don't think disabling ryuk globally is a good choice, when the rynk is disabled, developers need to clean up docker resources when testing locally. Could you please limit the scope and disable rynk in the module that needs to clean resource manually?

It seems ok that the container can be cleaned normally although we disable ryuk. I tried locally.

I see.

[youngyjd]

@jerqi seems working. not seeing errors related to permission anymore

thanks!

[tengqm]

Better add some comments to the source code explaining why we are doing this.
Comments for cases like this are very useful because this change is actually an experiment.
This toggling should be treated as [EXPERIMENTAL].

[jerryshao]

I agree with @tengqm that we should add comments to explain why do we need to add this configuration.