[#5756] Bug Fix : Warehouse parameter systematically required - #5923
Merged
Conversation
… REST type catalog.
…EHOUSE checks for presence in creatingCatalogWrapper for Iceberg
…e, without value checks.
…E\nRemoving systematic value check for WAREHOUSE parameter in REST request.
FANNG1
reviewed
Dec 20, 2024
tengqm
reviewed
Dec 21, 2024
| WAREHOUSE, | ||
| "Iceberg catalog warehouse config", | ||
| false /* immutable */, | ||
| null, /* defaultValue */ |
Contributor
There was a problem hiding this comment.
We could have prevented this kind of obvious errors if we apply a stricter coding style.
Can you help also wrap line 76?
Contributor
There was a problem hiding this comment.
Looks like that this is not updated yet?
…ments in Properties Metadata for Iceberg Catalog\nTesting that warehouse is not blank if necessary for some type of catalog for Iceberg.
Contributor
Author
Contributor
|
lgtm |
FANNG1
reviewed
Dec 22, 2024
|
|
||
| # version that is going to be updated automatically by releases | ||
| version = 0.8.0-incubating-SNAPSHOT | ||
| version = 0.7.0-incubating-SNAPSHOT |
Contributor
There was a problem hiding this comment.
please don't update the properties in gradle.properties, version is updated when we start releasing a new version.
Contributor
Author
There was a problem hiding this comment.
This is fixed now, thanks for the feedback
Contributor
Author
There was a problem hiding this comment.
oops sorry, that's done
Contributor
|
LGTM except one comments |
FANNG1
approved these changes
Dec 22, 2024
Contributor
|
Merging to main branch, thanks @fsalhi2 for your contribution. |
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Dec 23, 2024
…pache#5923) ### What changes were proposed in this pull request? Removed the systematic validations in Iceberg Config and modified the instantiation of the warehouse attribute and uri attribute in the IcebergCatalogWrapper to conform with the new possibility (REST). ### Why are the changes needed? The bug was blocking the creation of a rest catalog. Fix: [apache#5756](apache#5756) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? ./gradlew build && compileDistribution && assembleDistribution + creation of the docker image there : https://hub.docker.com/r/fsalhi2/gravitino Started gravitino with such configs : ``` ### Gravitino General Settings gravitino.auxService.names = iceberg-rest gravitino.iceberg-rest.classpath = iceberg-rest-server/libs, iceberg-rest-server/conf ### HTTP Server gravitino.iceberg-rest.host = 0.0.0.0 gravitino.iceberg-rest.httpPort = 9001 ### Storage gravitino.iceberg-rest.io-impl = org.apache.iceberg.aws.s3.S3FileIO gravitino.iceberg-rest.s3-access-key-id = XXXXX gravitino.iceberg-rest.s3-secret-access-key = XXXXXX gravitino.iceberg-rest.s3-path-style-access = true gravitino.iceberg-rest.s3-endpoint = http://minio:9000/ gravitino.iceberg-rest.s3-region = us-east-1 ### JDBC gravitino.iceberg-rest.catalog-backend = jdbc gravitino.iceberg-rest.uri = jdbc:mysql://mysql:3306/ gravitino.iceberg-rest.warehouse = s3://lake/catalog gravitino.iceberg-rest.jdbc.user = root gravitino.iceberg-rest.jdbc.password = XXXXXX gravitino.iceberg-rest.jdbc-driver = com.mysql.cj.jdbc.Driver ``` Was able to create a catalog through Web UI and start working on the scheme.
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Dec 29, 2024
…pache#5923) ### What changes were proposed in this pull request? Removed the systematic validations in Iceberg Config and modified the instantiation of the warehouse attribute and uri attribute in the IcebergCatalogWrapper to conform with the new possibility (REST). ### Why are the changes needed? The bug was blocking the creation of a rest catalog. Fix: [apache#5756](apache#5756) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? ./gradlew build && compileDistribution && assembleDistribution + creation of the docker image there : https://hub.docker.com/r/fsalhi2/gravitino Started gravitino with such configs : ``` ### Gravitino General Settings gravitino.auxService.names = iceberg-rest gravitino.iceberg-rest.classpath = iceberg-rest-server/libs, iceberg-rest-server/conf ### HTTP Server gravitino.iceberg-rest.host = 0.0.0.0 gravitino.iceberg-rest.httpPort = 9001 ### Storage gravitino.iceberg-rest.io-impl = org.apache.iceberg.aws.s3.S3FileIO gravitino.iceberg-rest.s3-access-key-id = XXXXX gravitino.iceberg-rest.s3-secret-access-key = XXXXXX gravitino.iceberg-rest.s3-path-style-access = true gravitino.iceberg-rest.s3-endpoint = http://minio:9000/ gravitino.iceberg-rest.s3-region = us-east-1 ### JDBC gravitino.iceberg-rest.catalog-backend = jdbc gravitino.iceberg-rest.uri = jdbc:mysql://mysql:3306/ gravitino.iceberg-rest.warehouse = s3://lake/catalog gravitino.iceberg-rest.jdbc.user = root gravitino.iceberg-rest.jdbc.password = XXXXXX gravitino.iceberg-rest.jdbc-driver = com.mysql.cj.jdbc.Driver ``` Was able to create a catalog through Web UI and start working on the scheme.
danhuawang
pushed a commit
to danhuawang/gravitino
that referenced
this pull request
Jun 9, 2026
…pache#5923) ### What changes were proposed in this pull request? Removed the systematic validations in Iceberg Config and modified the instantiation of the warehouse attribute and uri attribute in the IcebergCatalogWrapper to conform with the new possibility (REST). ### Why are the changes needed? The bug was blocking the creation of a rest catalog. Fix: [apache#5756](apache#5756) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? ./gradlew build && compileDistribution && assembleDistribution + creation of the docker image there : https://hub.docker.com/r/fsalhi2/gravitino Started gravitino with such configs : ``` ### Gravitino General Settings gravitino.auxService.names = iceberg-rest gravitino.iceberg-rest.classpath = iceberg-rest-server/libs, iceberg-rest-server/conf ### HTTP Server gravitino.iceberg-rest.host = 0.0.0.0 gravitino.iceberg-rest.httpPort = 9001 ### Storage gravitino.iceberg-rest.io-impl = org.apache.iceberg.aws.s3.S3FileIO gravitino.iceberg-rest.s3-access-key-id = XXXXX gravitino.iceberg-rest.s3-secret-access-key = XXXXXX gravitino.iceberg-rest.s3-path-style-access = true gravitino.iceberg-rest.s3-endpoint = http://minio:9000/ gravitino.iceberg-rest.s3-region = us-east-1 ### JDBC gravitino.iceberg-rest.catalog-backend = jdbc gravitino.iceberg-rest.uri = jdbc:mysql://mysql:3306/ gravitino.iceberg-rest.warehouse = s3://lake/catalog gravitino.iceberg-rest.jdbc.user = root gravitino.iceberg-rest.jdbc.password = XXXXXX gravitino.iceberg-rest.jdbc-driver = com.mysql.cj.jdbc.Driver ``` Was able to create a catalog through Web UI and start working on the scheme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removed the systematic validations in Iceberg Config and modified the instantiation of the warehouse attribute and uri attribute in the IcebergCatalogWrapper to conform with the new possibility (REST).
Why are the changes needed?
The bug was blocking the creation of a rest catalog.
Fix: #5756
Does this PR introduce any user-facing change?
No
How was this patch tested?
./gradlew build && compileDistribution && assembleDistribution + creation of the docker image there : https://hub.docker.com/r/fsalhi2/gravitino
Started gravitino with such configs :
Was able to create a catalog through Web UI and start working on the scheme.