Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Unify the name:utils -> util and the namespace of GraphAr::util #225

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Aug 16, 2023

Proposed changes

This change rename utils of GraphAr to util base convention of open source project.

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fixed issue #220

@acezen acezen requested a review from lixueclaire August 16, 2023 07:28
@acezen acezen changed the title [FEAT] unify the name:utils -> util and unify the namespace of gar::util [FEAT] Unify the name:utils -> util and unify the namespace of gar::util Aug 16, 2023
Signed-off-by: acezen <[email protected]>
@acezen
Copy link
Contributor Author

acezen commented Aug 16, 2023

hi, @Thespica, I rename all utils to util (include JAVA SDK), can you help me to review this change.
thanks a lot~

@acezen acezen changed the title [FEAT] Unify the name:utils -> util and unify the namespace of gar::util [FEAT] Unify the name:utils -> util and unify the namespace of GraphAr::util Aug 16, 2023
@acezen acezen changed the title [FEAT] Unify the name:utils -> util and unify the namespace of GraphAr::util [FEAT] Unify the name:utils -> util and the namespace of GraphAr::util Aug 16, 2023
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@Thespica
Copy link
Contributor

LGTM~ Thanks for your work : )

@acezen acezen merged commit 320f868 into apache:main Aug 18, 2023
@acezen acezen deleted the 220-unify-namespace branch August 18, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants