You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
This issue is about designing of namespace. It's really confusing that there are two similar namespace called utils and util, but both are under subdirectory and header called utils.
Unify name of directories, headers and namespaces to utils or util.
Designing more OOP, reduce functions beyond classes: It will be easier to call C++ functions in Java if we put functions(static or not) in classes rather than in namespaces, because functions must rely on class.
Is your feature request related to a problem? Please describe.
This issue is about designing of namespace. It's really confusing that there are two similar namespace called
utils
andutil
, but both are under subdirectory and header called utils.https://github.com/alibaba/GraphAr/blob/3cd7038cd884bd387d9d005b3165118a6fcfcd31/cpp/include/gar/utils/utils.h#L41
https://github.com/alibaba/GraphAr/blob/3cd7038cd884bd387d9d005b3165118a6fcfcd31/cpp/include/gar/utils/reader_utils.h#L29C18-L29C18
Describe the solution you'd like
Unify name of directories, headers and namespaces to
utils
orutil
.Designing more OOP, reduce functions beyond classes: It will be easier to call C++ functions in Java if we put functions(static or not) in classes rather than in namespaces, because functions must rely on class.
Good example:
https://github.com/alibaba/GraphAr/blob/3cd7038cd884bd387d9d005b3165118a6fcfcd31/cpp/include/gar/graph_info.h#L1091
Bad example:
https://github.com/alibaba/GraphAr/blob/3cd7038cd884bd387d9d005b3165118a6fcfcd31/cpp/include/gar/utils/reader_utils.h#L46
Maybe we can keep origin functions and copy needed to classes.
The text was updated successfully, but these errors were encountered: