[IN-PROGRESS] GORA-698 Geode DataStore #273
Conversation
| private Region<K, T> region; | ||
| private Properties geodeProperties; | ||
|
|
||
|
|
There was a problem hiding this comment.
Extra spaces removed
| geodeProperties = properties; | ||
|
|
||
| Properties clientProperties = clientCache.getDistributedSystem().getProperties(); | ||
| if (userName != null) { |
There was a problem hiding this comment.
What if username is null and password is not? How about throwing an exception in that case?
There was a problem hiding this comment.
Added some code to throw exception
|
|
||
| @Override | ||
| public Result<K, T> execute(Query<K, T> query) { | ||
|
|
There was a problem hiding this comment.
Extra space removed
| @@ -0,0 +1,187 @@ | |||
| package org.apache.gora.geode.store; | |||
|
|
|||
| import org.apache.geode.cache.*; | |||
There was a problem hiding this comment.
Replaced wildcard import statements with only required ones.
| * Tests extending {@link DataStoreTestBase} | ||
| * which run the base JUnit test suite for Gora. | ||
| */ | ||
| public class TestGeodeStore extends DataStoreTestBase { |
|
@CalvinKirs Do you have any input on the PR related to Geode work? |
I will take a look later :) |
|
@himanshuacharya95 Can you please address the remaining request changes? |
|
Theres some in complete work left in this PR, I will merge this PR for now and take things forward. |
Pending Items Test Cases