Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-1885] Ensure All Logged Timestamps are in UTC #3747

Merged

Conversation

umustafi
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Ensure all logs are in UTC for ease of comparison between other logging done.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2023

Codecov Report

Merging #3747 (84c006c) into master (e07450f) will decrease coverage by 0.14%.
Report is 2 commits behind head on master.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #3747      +/-   ##
============================================
- Coverage     47.14%   47.00%   -0.14%     
+ Complexity    10878    10851      -27     
============================================
  Files          2147     2147              
  Lines         84889    84898       +9     
  Branches       9418     9419       +1     
============================================
- Hits          40018    39906     -112     
- Misses        41246    41358     +112     
- Partials       3625     3634       +9     
Files Changed Coverage Δ
...vice/modules/orchestration/FlowTriggerHandler.java 10.63% <0.00%> (ø)
.../modules/scheduler/GobblinServiceJobScheduler.java 70.08% <66.66%> (-4.65%) ⬇️

... and 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

* Takes a given Date object and converts the timezone to UTC before returning the number of millseconds since epoch
* @param date
*/
public static long asUTCEpochMillis(Date date) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if public for more than just testability, it may belong in a utility class rather than here

@Will-Lo Will-Lo merged commit 8ae0a6c into apache:master Aug 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants