-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GOBBLIN-1885] Ensure All Logged Timestamps are in UTC #3747
[GOBBLIN-1885] Ensure All Logged Timestamps are in UTC #3747
Conversation
...e/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #3747 +/- ##
============================================
- Coverage 47.14% 47.00% -0.14%
+ Complexity 10878 10851 -27
============================================
Files 2147 2147
Lines 84889 84898 +9
Branches 9418 9419 +1
============================================
- Hits 40018 39906 -112
- Misses 41246 41358 +112
- Partials 3625 3634 +9
... and 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
* Takes a given Date object and converts the timezone to UTC before returning the number of millseconds since epoch | ||
* @param date | ||
*/ | ||
public static long asUTCEpochMillis(Date date) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if public
for more than just testability, it may belong in a utility class rather than here
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Ensure all logs are in UTC for ease of comparison between other logging done.
Tests
Commits