Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-1883] Multiple tokens in ProxiedFileSystem #3744

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

arjun4084346
Copy link
Contributor

@arjun4084346 arjun4084346 commented Aug 17, 2023

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    While creating a proxied file system, sometimes we need multiple tokens. e.g. when there exists multiple namenodes

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    trivial change

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@arjun4084346 arjun4084346 force-pushed the multipleTokens branch 2 times, most recently from ac40cbe to f26fe08 Compare August 17, 2023 21:35
@arjun4084346 arjun4084346 changed the title [draft] Multiple tokens [GOBBLIN-1883] Multiple tokens in ProxiedFileSystem Aug 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #3744 (99f0507) into master (69d7e0f) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #3744      +/-   ##
============================================
- Coverage     47.09%   47.02%   -0.08%     
+ Complexity    10877    10848      -29     
============================================
  Files          2147     2147              
  Lines         84859    84868       +9     
  Branches       9416     9417       +1     
============================================
- Hits          39968    39910      -58     
- Misses        41264    41326      +62     
- Partials       3627     3632       +5     
Files Changed Coverage Δ
...rg/apache/gobblin/util/ProxiedFileSystemCache.java 0.00% <0.00%> (ø)
...rg/apache/gobblin/util/ProxiedFileSystemUtils.java 0.00% <0.00%> (ø)
...main/java/org/apache/gobblin/util/WriterUtils.java 44.96% <0.00%> (ø)

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Will-Lo Will-Lo merged commit c6f9f42 into apache:master Aug 17, 2023
6 checks passed
umustafi pushed a commit to umustafi/gobblin that referenced this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants