Skip to content

[GOBBLIN-1780] Refactor/rename YarnServiceIT to YarnServiceTest#3637

Merged
Will-Lo merged 2 commits intoapache:masterfrom
AndyJiang99:andjiang/YarnServiceTest_Rename
Feb 7, 2023
Merged

[GOBBLIN-1780] Refactor/rename YarnServiceIT to YarnServiceTest#3637
Will-Lo merged 2 commits intoapache:masterfrom
AndyJiang99:andjiang/YarnServiceTest_Rename

Conversation

@AndyJiang99
Copy link
Copy Markdown
Contributor

@AndyJiang99 AndyJiang99 commented Feb 7, 2023

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

This renaming is done as YarnServiceTest currently is disabled on CI testing. We would like to add unit tests in this file that are run during CI, but this requires removing some components. This rename is so we don't override YarnServiceTest Git history, simply a rename to YarnServiceIT. After renaming the tests to YarnServiceIT, there will be another PR that has a new file of the original name (YarnServiceTest.java) will be created, new unit tests will be created there, and those new tests will run in CI testing.

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Copy link
Copy Markdown
Contributor

@homatthew homatthew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work splitting up the change

@AndyJiang99 AndyJiang99 changed the title Refactor/rename YarnServiceIT to YarnServiceTest [GOBBLIN-1780] Refactor/rename YarnServiceIT to YarnServiceTest Feb 7, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 7, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.58%. Comparing base (667d797) to head (4309c2b).
⚠️ Report is 488 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3637      +/-   ##
============================================
+ Coverage     46.56%   46.58%   +0.01%     
- Complexity    10666    10673       +7     
============================================
  Files          2133     2133              
  Lines         83541    83557      +16     
  Branches       9288     9290       +2     
============================================
+ Hits          38905    38929      +24     
+ Misses        41074    41066       -8     
  Partials       3562     3562              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Will-Lo Will-Lo merged commit 69f3f9c into apache:master Feb 7, 2023
umustafi pushed a commit to umustafi/gobblin that referenced this pull request Feb 8, 2023
…he#3637)

* Refactor YarnServiceIT to YarnServiceTest

* Refactor additional files
phet added a commit to phet/gobblin that referenced this pull request Feb 13, 2023
* upstream/master:
  [GOBBLIN-1774] Util for detecting non optional uniontypes Hive tables (apache#3632)
  [GOBBLIN-1773] Fix bugs in quota manager (apache#3636)
  [GOBBLIN-1782] Fix Merge State for Flow Pending Resume statuses (apache#3639)
  [GOBBLIN-1755] Support extended ACLs and sticky bit for file based distcp (apache#3616)
  [GOBBLIN-1780] Refactor/rename YarnServiceIT to YarnServiceTest (apache#3637)
  [GOBBLIN-1778] Add house keeping thread in DagManager to periodically sync in memory state with mysql table (apache#3635)
  Register gauge metrics for change monitors (apache#3634)
phet added a commit to phet/gobblin that referenced this pull request Mar 24, 2023
* upstream/master:
  [GOBBLIN-1774] Util for detecting non optional uniontypes Hive tables (apache#3632)
  [GOBBLIN-1773] Fix bugs in quota manager (apache#3636)
  [GOBBLIN-1782] Fix Merge State for Flow Pending Resume statuses (apache#3639)
  [GOBBLIN-1755] Support extended ACLs and sticky bit for file based distcp (apache#3616)
  [GOBBLIN-1780] Refactor/rename YarnServiceIT to YarnServiceTest (apache#3637)
  [GOBBLIN-1778] Add house keeping thread in DagManager to periodically sync in memory state with mysql table (apache#3635)
  Register gauge metrics for change monitors (apache#3634)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants