[GOBBLIN-1780] Refactor/rename YarnServiceIT to YarnServiceTest#3637
Merged
Will-Lo merged 2 commits intoapache:masterfrom Feb 7, 2023
Merged
[GOBBLIN-1780] Refactor/rename YarnServiceIT to YarnServiceTest#3637Will-Lo merged 2 commits intoapache:masterfrom
Will-Lo merged 2 commits intoapache:masterfrom
Conversation
homatthew
reviewed
Feb 7, 2023
gobblin-yarn/src/test/java/org/apache/gobblin/yarn/YarnServiceTestWithExpiration.java
Show resolved
Hide resolved
homatthew
approved these changes
Feb 7, 2023
Contributor
homatthew
left a comment
There was a problem hiding this comment.
Good work splitting up the change
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3637 +/- ##
============================================
+ Coverage 46.56% 46.58% +0.01%
- Complexity 10666 10673 +7
============================================
Files 2133 2133
Lines 83541 83557 +16
Branches 9288 9290 +2
============================================
+ Hits 38905 38929 +24
+ Misses 41074 41066 -8
Partials 3562 3562 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Will-Lo
approved these changes
Feb 7, 2023
umustafi
pushed a commit
to umustafi/gobblin
that referenced
this pull request
Feb 8, 2023
…he#3637) * Refactor YarnServiceIT to YarnServiceTest * Refactor additional files
phet
added a commit
to phet/gobblin
that referenced
this pull request
Feb 13, 2023
* upstream/master: [GOBBLIN-1774] Util for detecting non optional uniontypes Hive tables (apache#3632) [GOBBLIN-1773] Fix bugs in quota manager (apache#3636) [GOBBLIN-1782] Fix Merge State for Flow Pending Resume statuses (apache#3639) [GOBBLIN-1755] Support extended ACLs and sticky bit for file based distcp (apache#3616) [GOBBLIN-1780] Refactor/rename YarnServiceIT to YarnServiceTest (apache#3637) [GOBBLIN-1778] Add house keeping thread in DagManager to periodically sync in memory state with mysql table (apache#3635) Register gauge metrics for change monitors (apache#3634)
phet
added a commit
to phet/gobblin
that referenced
this pull request
Mar 24, 2023
* upstream/master: [GOBBLIN-1774] Util for detecting non optional uniontypes Hive tables (apache#3632) [GOBBLIN-1773] Fix bugs in quota manager (apache#3636) [GOBBLIN-1782] Fix Merge State for Flow Pending Resume statuses (apache#3639) [GOBBLIN-1755] Support extended ACLs and sticky bit for file based distcp (apache#3616) [GOBBLIN-1780] Refactor/rename YarnServiceIT to YarnServiceTest (apache#3637) [GOBBLIN-1778] Add house keeping thread in DagManager to periodically sync in memory state with mysql table (apache#3635) Register gauge metrics for change monitors (apache#3634)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
This renaming is done as YarnServiceTest currently is disabled on CI testing. We would like to add unit tests in this file that are run during CI, but this requires removing some components. This rename is so we don't override YarnServiceTest Git history, simply a rename to YarnServiceIT. After renaming the tests to YarnServiceIT, there will be another PR that has a new file of the original name (YarnServiceTest.java) will be created, new unit tests will be created there, and those new tests will run in CI testing.
JIRA
Description
Tests
Commits