[GLUTEN-5248][VL] Directly pass legacySizeOfNull to native size function#6014
Merged
marin-ma merged 4 commits intoapache:mainfrom Jul 2, 2024
Merged
[GLUTEN-5248][VL] Directly pass legacySizeOfNull to native size function#6014marin-ma merged 4 commits intoapache:mainfrom
marin-ma merged 4 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
Member
Author
|
Run Gluten Clickhouse CI |
Member
Author
|
@marin-ma, could you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Spark Size function's legacySizeOfNull is determined either by other functions like
ArraySizeto specify a value or by Spark's configuration. Just depending on configuration will cause result mismatch issue forArraySizefunction.With the fix in velox: facebookincubator/velox#10100, we need to directly pass this value of instantiated
Sizeto native function.Depends on a fix in velox:
facebookincubator/velox#10100
Fixes #5248.
How was this patch tested?
Added test.