Skip to content

Conversation

@nabarunnag
Copy link
Contributor

…rride CompiledValue.RESULT_LIMIT (#7010)"

This reverts commit 67359dc

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

…rride CompiledValue.RESULT_LIMIT (apache#7010)"

This reverts commit 67359dc
@nabarunnag nabarunnag added windows add this label to get Windows JDK11 PR checks too windows-jdk17 add this label to get Windows JDK17 PR checks too windows-jdk8 add this label to get Windows JDK8 PR checks too labels Jun 8, 2022
@onichols-pivotal onichols-pivotal requested a review from mkevo June 8, 2022 19:31
Copy link
Contributor

@mkevo mkevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any comment why this should be reverted?

@nabarunnag
Copy link
Contributor Author

@mkevo as mentioned in the dev mail, we are planning to put the commit in develop again after fixing the problem that was brought up by you in dev list.
We are planning to release 1.15 (which is planned for this month) and then try to fix the issue and put it back into develop.
We need to revert the commit in develop to back port the revert to 1.15 ( its the release protocol). After 1.15.0 is released, we can put the complete solution back in

@nabarunnag nabarunnag merged commit 784327a into apache:develop Jun 9, 2022
nabarunnag added a commit that referenced this pull request Jun 9, 2022
…rride CompiledValue.RESULT_LIMIT (#7010)" (#7787)

This reverts commit 67359dc

(cherry picked from commit 784327a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

windows add this label to get Windows JDK11 PR checks too windows-jdk8 add this label to get Windows JDK8 PR checks too windows-jdk17 add this label to get Windows JDK17 PR checks too

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants